You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Inspector 2.0] Stack overflow error when building the new widget tree with implementation widgets #8553
A Flutter web customer with a large widget tree reported that the new inspector is crashing for them when "show implementation widgets" is toggled on.
When it crashes, they see a "stack overflow" error in the Chrome DevTools console. I've confirmed that this is due to us building the widget tree's JSON object recursively, and it seems like we are hitting Chrome's stack limit.
They've confirmed that they don't see the stack overflow error when the widget tree JSON is built iteratively instead.
Note: The iterative approach should only be used to build the widget tree itself, not to fetch any of the properties or details of a widget. This is because those require the recursive implementation to call toJsonMap for each node to get the details provided by the subclass implementations.
Activity
elliette commentedon Nov 25, 2024
Note: The iterative approach should only be used to build the widget tree itself, not to fetch any of the properties or details of a widget. This is because those require the recursive implementation to call
toJsonMapfor each node to get the details provided by the subclass implementations.[Widget Inspector] Fix stack overflow error for Flutter web when requ…