Skip to content

Rev versions for release 0.1.15 - #1616

Merged
DaveShuckerow merged 3 commits into
flutter:masterfrom
DaveShuckerow:release_0_1_15
Feb 7, 2020
Merged

DaveShuckerow merged 3 commits into
flutter:masterfrom
DaveShuckerow:release_0_1_15

Conversation

@DaveShuckerow

@DaveShuckerow DaveShuckerow commented Feb 7, 2020 •

Copy link
Copy Markdown
Contributor

Includes the patch for #1610

@devoncarew devoncarew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (but I have not run through the devtools release process myself)

@kenzieschmoll kenzieschmoll left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update the version in devtools.dart as well as update the changelog.
see https://github.com/flutter/devtools/blob/master/tool/README.md

@DaveShuckerow
DaveShuckerow merged commit 6978341 into flutter:master Feb 7, 2020
@@ -1,3 +1,9 @@
## 0.1.15 2020-02-07
* Fix a stack overflow error that was caused by a change in Dart's RTI implementation [#1615](https://github.com/flutter/devtools/pull/1615).
* Hide annotations that Flutter re-exports [#1606](https://github.com/flutter/devtools/pull/1606)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we haven't been including non-user-facing changes into the changelog, but in the spirit of automating this process in the future so the changelog is generated from all the commits, I'm fine with leaving the last three.

If we automate this in the future, we'd need to ensure we have quality commit messages as part of the review.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually ended up omitting some of the PRs because they were redundant. Automating this to get meaningful changelogs would take a bit more work than it seems like at first.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm suggesting automating it and then manually scraping out the stuff that doesn't matter, not automating to only grab the stuff that matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants