Repository navigation
Rev versions for release 0.1.15 - #1616
Conversation
devoncarew
left a comment
There was a problem hiding this comment.
lgtm (but I have not run through the devtools release process myself)
There was a problem hiding this comment.
You'll need to update the version in devtools.dart as well as update the changelog.
see https://github.com/flutter/devtools/blob/master/tool/README.md
| @@ -1,3 +1,9 @@ | |||
| ## 0.1.15 2020-02-07 | |||
| * Fix a stack overflow error that was caused by a change in Dart's RTI implementation [#1615](https://github.com/flutter/devtools/pull/1615). | |||
| * Hide annotations that Flutter re-exports [#1606](https://github.com/flutter/devtools/pull/1606) | |||
There was a problem hiding this comment.
Generally we haven't been including non-user-facing changes into the changelog, but in the spirit of automating this process in the future so the changelog is generated from all the commits, I'm fine with leaving the last three.
If we automate this in the future, we'd need to ensure we have quality commit messages as part of the review.
There was a problem hiding this comment.
I actually ended up omitting some of the PRs because they were redundant. Automating this to get meaningful changelogs would take a bit more work than it seems like at first.
There was a problem hiding this comment.
I'm suggesting automating it and then manually scraping out the stuff that doesn't matter, not automating to only grab the stuff that matters.
Includes the patch for #1610