Repository navigation
Use new BreadcrumbNavigator widget in code size screen - #2303
Conversation
| }, | ||
| ), | ||
| ); | ||
| final breadcrumbs = List<Breadcrumb>.generate(pathFromRoot.length, (index) { |
There was a problem hiding this comment.
nit: there probably won't be enough breadcrumbs to matter but it could be nice to continue to use itemBuilder like the code was previously so you don't build the breadcrumb widgets until they are needed. you're already using List.generate so the api shape seems about identical. I would just have the Breadcrumb navigator take an arbitrary widget as a child so you can specify the ListView here like it was done before.
There was a problem hiding this comment.
Switched to a builder constructor so that we still get the benefit of ListView.builder but the consumer does not have to be responsible for the List widget code.
|
Landing on red test flake - we may want to disable that test, as it is blocking development pretty bad lately. |
2 participants
In the user studies, we observed that it was not obvious to users that the breadcrumbs were clickable. This breadcrumb Navigator is similar to an IDE breadcrumb navigator and should feel more familiar to users. The breadcrumbs also look more clickable in this version.