Skip to content

Support selection within the TextView and fix bug showing pause location. - #2665

Merged
jacob314 merged 1 commit into
flutter:masterfrom
jacob314:fix_spacing
Feb 2, 2021
Merged

jacob314 merged 1 commit into
flutter:masterfrom
jacob314:fix_spacing

Conversation

@jacob314

@jacob314 jacob314 commented Feb 2, 2021

Copy link
Copy Markdown
Contributor

Fyi @bkony, looks like syntax highlighting broken this. For some reason, the fixed width font isn't really exactly fixed width once you have a bunch of separate TextSpans.
I'm sure there is a better way to do this but this was quick and easy.

Also added single line text selection as it is better than nothing.

@jacob314

jacob314 commented Feb 2, 2021

Copy link
Copy Markdown
Contributor Author

Fyi @grouma I think you were seeing this issue.

@grouma

grouma commented Feb 2, 2021

Copy link
Copy Markdown
Member

I was experiencing something similar for our internal build. It wasn't clear to me if it was a font loading issue or this one though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants