Skip to content

Handle pre-release versions in Flutter version parsing and comparison - #3134

Merged
kenzieschmoll merged 3 commits into
flutter:masterfrom
kenzieschmoll:version
Jun 17, 2021
Merged

kenzieschmoll merged 3 commits into
flutter:masterfrom
kenzieschmoll:version

Conversation

@kenzieschmoll

Copy link
Copy Markdown
Member

This PR also uses this new version parsing code to determine whether to show the legacy or new performance page.

Comment thread packages/devtools_app/lib/src/version.dart
Comment thread packages/devtools_app/lib/src/version.dart

@jacob314 jacob314 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kenzieschmoll

Copy link
Copy Markdown
Member Author

Build is broken due to unrelated Inspector Golden failures. Will send a follow up PR to fix the bots.

@kenzieschmoll
kenzieschmoll merged commit d9bc560 into flutter:master Jun 17, 2021
@kenzieschmoll
kenzieschmoll deleted the version branch June 17, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants