Repository navigation
Adopt stager for DevTools. - #4463
Merged
Merged
Conversation
| **/generated/not_namespaced_r_class_sources/ | ||
| **/build/ | ||
| packages/devtools_test/lib/src/mocks/generated.mocks.dart | ||
| **/*.stager_app.dart |
Member
There was a problem hiding this comment.
is there a reason we don't want this checked in?
Contributor
Author
There was a problem hiding this comment.
they are generated
but we can check them in...
It may be convenient
What do you think?
Member
There was a problem hiding this comment.
okay, generally don't want to check generated code in if we can avoid it. if we don't check them in, what does it look like for someone who doesn't have the generated files on their machine? should we add generating these stager_app files to the generate code scripts we have?
Contributor
Author
There was a problem hiding this comment.
I thought it is already here, but just realized it is for other package. Added.
kenzieschmoll
approved these changes
Sep 13, 2022
4 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.