Repository navigation
Add GC statistics to the allocation profile in VM developer mode - #5074
Merged
Merged
Conversation
This change surfaces some details about GC performance, including: - Heap space usage - Heap space capacity - # of collections - Average collection latency (i.e., time taken to perform a GC)
| if (stats.averageCollectionTime.isNaN) { | ||
| return 0; | ||
| } | ||
| return getGCStats(dataObject).averageCollectionTime * 1000; |
Member
There was a problem hiding this comment.
we should use the msText helper here
Contributor
Author
There was a problem hiding this comment.
We use msText below.
| children: [ | ||
| SizedBox( | ||
| // _GCStatsTable is a table with two header rows (column groups | ||
| // and columns) and one data row. We add a slight padding to |
Member
There was a problem hiding this comment.
can we use a Padding widget to add this padding so that it is more clear what the padding value is?
Contributor
Author
There was a problem hiding this comment.
Maybe padding is the wrong word here, but that doesn't accomplish what this extra 1 pixel does. The child of SizedBox needs an extra pixel of space to disable the scrolling behavior of the underlying table. Padding will just add the extra pixel around the child widget without disabling the scroll behavior.
kenzieschmoll
approved these changes
Jan 25, 2023
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change surfaces some details about GC performance, including:
Screenshot:
RELEASE_NOTE_EXCEPTION=VM developer functionality