Repository navigation
Add support for viewing data history after app disconnect - #5509
Merged
Merged
Conversation
bkonyi
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support to "review history" after an app disconnect for screens that support offline data viewing. Right now, that is only the Performance page and the Cpu Profiler page, but when other pages support offline viewing, we will get this "review history" behavior for free.
The workflow is as follows:
One other change is that the "Review History" button will only show up if there is some pending offline data to show.
Work towards #4108. I have a todo to add testing. As I explained in the issue, this feature is currently completely broken, so landing my change will not make this feature any more broken if something were to go wrong. With the upcoming deadline early next week, there are more important issues to address than adding this test, but I will come back to this and clean it up.