Skip to content

Selecting a stack frame scrolls the script location into view - #5722

Merged
elliette merged 15 commits into
flutter:masterfrom
elliette:issue-5707
Apr 27, 2023
Merged

elliette merged 15 commits into
flutter:masterfrom
elliette:issue-5707

Conversation

@elliette

@elliette elliette commented Apr 26, 2023 •

Copy link
Copy Markdown
Member

Fixes #5707
Work towards #5703

scroll to line

@elliette
elliette requested a review from a team as a code owner April 26, 2023 20:04
@elliette
elliette requested review from bkonyi and removed request for a team April 26, 2023 20:04
@elliette
elliette marked this pull request as draft April 26, 2023 21:09
@elliette

Copy link
Copy Markdown
Member Author

[Converted back to draft] Need to update the interaction with the search in file dialog so they aren't competing to scroll to different lines


Finder findDebuggerButtonWithTitle(String title) =>
find.byWidgetPredicate((Widget widget) {
if (widget is DebuggerButton && widget.title == title) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return widget is DebuggerButton && widget.title == title;? :-)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 Thanks!

@elliette
elliette marked this pull request as ready for review April 27, 2023 17:51
@auto-submit

auto-submit Bot commented Apr 27, 2023

Copy link
Copy Markdown

auto label is removed for flutter/devtools, pr: 5722, due to - The status or check suite Dart Code Metrics has failed. Please fix the issues identified (or deflake) before re-applying this label.

@elliette
elliette merged commit eea5793 into flutter:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking on a stackframe takes you to the start of the file, not the line location

2 participants