Repository navigation
Add test script for flutter/tests - #5785
Conversation
|
|
||
| # Test devtools_app | ||
| cd ../devtools_app | ||
| flutter test test/ |
There was a problem hiding this comment.
should our integration tests be run too?
There was a problem hiding this comment.
They will need more work to prepare them for flutter/tests. I cannot get them to pass currently under the test conditions of flutter/tests. I am not familiar with devtools integration tests so I cannot change them to work with flutter/tests right now.
I think this is a really good start to prevent us from breaking devtools in flutter/flutter, it should catch the majority of changes that would affect devtools.
There was a problem hiding this comment.
Agreed, this should catch most breakages. Thanks, Kate!
|
You'll be able to land this hopefully after #5786 lands and you can merge it in. |
|
If you merge master, the failures here should be resolved. |
3 participants
This adds a test script for running devtools tests in flutter/tests.
It also removes a print statement from a test since flutter/tests expects no output from a passing test.
Part of #4433
Once this lands, I can update in flutter/tests#258 to close the issue.
Pre-launch Checklist
///).If you need help, consider asking for help on Discord.