Repository navigation
File names should only be updated if parsing the file succeeds - #5827
Merged
Merged
Conversation
| /// Show the given script location (without updating the script navigation | ||
| /// history). | ||
| void _showScriptLocation( | ||
| /// history). Returns a boolean value representing success or failure. |
Member
There was a problem hiding this comment.
dart doc nit: put empty line after first sentence
| await tester.pumpWidget( | ||
| wrapWithControllers( | ||
| const DebuggerScreenBody(), | ||
| const NotificationsView( |
Member
There was a problem hiding this comment.
wrapWithControllers already includes a NotificationsView in the widget tree, so we shouldn't need to add this here
kenzieschmoll
approved these changes
May 22, 2023
kenzieschmoll
left a comment
kenzieschmoll
left a comment
Member
There was a problem hiding this comment.
a couple nits then lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5709
Work towards #5703
Before we were wrapping our script parsing step in an
unawaited, therefore we weren't waiting for the parsing to succeed to update the file name.This meant that:
Now we wait for parsing to succeed to update the file name. If parsing fails, we show an error to the user.