Repository navigation
Remove integration with leak_tracker. - #6591
Merged
Merged
Conversation
bkonyi
approved these changes
Oct 25, 2023
bkonyi
left a comment
bkonyi
left a comment
Contributor
There was a problem hiding this comment.
LGTM. However, out of curiosity, why are we removing this?
| import 'package:devtools_shared/devtools_shared.dart'; | ||
| import 'package:flutter/foundation.dart'; | ||
| import 'package:leak_tracker/devtools_integration.dart'; | ||
|
|
Contributor
There was a problem hiding this comment.
Nit: this space can be removed.
Contributor
Author
The integration is eroded significantly and stopped working, as we switched focus from detecting leaks for running app to detecting leaks in regression tests. It will be easier to recreate the integration in new form, than to maintain it. |
polina-c
marked this pull request as ready for review
October 25, 2023 19:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will return it in another form when leak_tracker is ready.