Skip to content

Handle breaking changes in package:vm_service v14 - #6953

Merged
derekxu16 merged 8 commits into
flutter:masterfrom
derekxu16:handle-changes-in-pkg-vm-service
Feb 2, 2024
Merged

derekxu16 merged 8 commits into
flutter:masterfrom
derekxu16:handle-changes-in-pkg-vm-service

Conversation

@derekxu16

Copy link
Copy Markdown
Contributor

package:vm_service v14 includes breaking changes to the dart:io service extensions. This PR updates the package:vm_service constraint to ^14.0.0 and updates DevTools in response to those changes.

@derekxu16
derekxu16 force-pushed the handle-changes-in-pkg-vm-service branch from bddf37f to 8f3fb23 Compare January 8, 2024 16:09
@derekxu16
derekxu16 force-pushed the handle-changes-in-pkg-vm-service branch from 8f3fb23 to e231f34 Compare January 16, 2024 21:10
@derekxu16
derekxu16 marked this pull request as ready for review January 16, 2024 21:11
@derekxu16
derekxu16 requested review from a team, bkonyi and kenzieschmoll as code owners January 16, 2024 21:11
Comment thread packages/devtools_app/lib/src/screens/network/network_controller.dart Outdated
Comment thread packages/devtools_app/lib/src/screens/network/network_controller.dart Outdated
Comment thread packages/devtools_app/lib/src/screens/network/network_service.dart Outdated
Comment thread packages/devtools_app_shared/pubspec.yaml

@kenzieschmoll kenzieschmoll left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one request to de-dupe. then lgtm

Comment thread packages/devtools_app/lib/src/screens/network/network_service.dart Outdated
Comment thread packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
@derekxu16
derekxu16 force-pushed the handle-changes-in-pkg-vm-service branch from fac7642 to 2d158f8 Compare January 18, 2024 15:42
@derekxu16
derekxu16 force-pushed the handle-changes-in-pkg-vm-service branch 2 times, most recently from 8f67165 to a488936 Compare January 31, 2024 17:21
@christopherfujino

Copy link
Copy Markdown
Contributor

@derekxu16 I rolled vm_service 14 to flutter/flutter in flutter/flutter#141427

@derekxu16
derekxu16 force-pushed the handle-changes-in-pkg-vm-service branch 2 times, most recently from 565eebb to 3d8b718 Compare February 1, 2024 19:18
@derekxu16

Copy link
Copy Markdown
Contributor Author

@derekxu16 I rolled vm_service 14 to flutter/flutter in flutter/flutter#141427

Thanks!

Comment thread flutter-candidate.txt Outdated
@derekxu16
derekxu16 force-pushed the handle-changes-in-pkg-vm-service branch from 3d8b718 to c813f7a Compare February 2, 2024 20:30
@derekxu16

derekxu16 commented Feb 2, 2024 •

Copy link
Copy Markdown
Contributor Author

There is currently a mismatch between the layout of the data sent by the VM and the layout of data expected by package:vm_service 14.0.0. This is because I can't land the corresponding VM change (https://dart-review.googlesource.com/c/sdk/+/341120) without updating DevTools and rolling it internally first, or else I will break dart-cbuild.

The problem described above actually didn't apply, I just needed to change a call in NetworkController from service.socketProfilingEnabledWrapper to service.socketProfilingEnabled.

@derekxu16
derekxu16 force-pushed the handle-changes-in-pkg-vm-service branch from 20ca33c to 6d96471 Compare February 2, 2024 21:51
@derekxu16
derekxu16 force-pushed the handle-changes-in-pkg-vm-service branch from 6d96471 to 59b31d6 Compare February 2, 2024 22:04
@derekxu16
derekxu16 merged commit 3b610d9 into flutter:master Feb 2, 2024
@derekxu16
derekxu16 deleted the handle-changes-in-pkg-vm-service branch February 2, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants