Skip to content

Fix test failures that started appearing after package:vm_service was updated to 14.2.5 - #8203

Closed
bkonyi wants to merge 5 commits into
flutter:masterfrom
bkonyi:fix_failures_after_vm_service_14.2.5
Closed

bkonyi wants to merge 5 commits into
flutter:masterfrom
bkonyi:fix_failures_after_vm_service_14.2.5

Conversation

@bkonyi

@bkonyi bkonyi commented Aug 16, 2024

Copy link
Copy Markdown
Contributor

These failures are blocking the Flutter customer tests.

@goderbauer

Copy link
Copy Markdown
Member

@bkonyi After this has landed, can you revert flutter/tests#397 and bump the devtools hash in there to pick up this change here please?

@bkonyi
bkonyi requested a review from a team as a code owner August 19, 2024 15:02
Comment thread packages/devtools_app_shared/lib/src/service/service_extension_manager.dart Outdated
@kenzieschmoll

Copy link
Copy Markdown
Member

Looks like the goldens will need to be updated: devtools_tool fix-goldens --run-id=10455860699

Also, the new version of Flutter may have triggered the failure you are seeing on the benchmark-performance CI job.

@kenzieschmoll

Copy link
Copy Markdown
Member

closing in favor of #8224, which patches in the changes from this PR.

@bkonyi
bkonyi deleted the fix_failures_after_vm_service_14.2.5 branch August 23, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants