Repository navigation
Inspector infers correct pub root directory for widget previews - #8808
Merged
Merged
Conversation
elliette
requested review from
bkonyi and
kenzieschmoll
and removed request for
a team
January 24, 2025 23:28
elliette
changed the title
bkonyi
approved these changes
Jan 30, 2025
bkonyi
left a comment
bkonyi
left a comment
Contributor
There was a problem hiding this comment.
Would build not be a better directory to look for if we have a running application?
Also, I'm not sure what the difference between the 'lib' / 'web' case and 'packages', but I assume there's a reason since that's just a refactor... :)
Overall, LGTM.
Member
Author
Possibly! But I don't want to change the existing logic (which currently works) unless there's a need to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8807
I'm assuming we never want to set a directory in
.dart_toolas a pub root directory, but in case we do we can change the logic to specifically only exclude thewidget_previews_scaffolddirectory.