Repository navigation
Don't connect the SSE API when running embedded - #9020
Merged
Merged
Conversation
kenzieschmoll
approved these changes
Mar 11, 2025
Contributor
Author
|
I didn't notice when testing this that the DTD connection was missing in this mode - I've opened #9023 with some notes about the issue. If we can agree a fix that's fairly simple I can just fix it, otherwise I can revert this in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents the SSE connection from being connected when running embedded. DevTools was already capable of running without this connection (since it discards exceptions connecting, and the server may be unavailable in some contexts).
It doesn't fix any issues, but it increases the number of embedded DevTools pages that can be shown in VS Code before they stop working (before this fix, I couldn't open every page, but with this change I can open them all and should have a few connections to spare).
See #8298
See #8763
I've verified the connection is still being made when running in the browser, but not when embedded.
@kenzieschmoll I don't know if we have a good way to test something like this (I think there were some with the server that moved to the SDK).