Skip to content

Combine the pause and resume buttons in the debugger - #9095

Merged
kenzieschmoll merged 2 commits into
flutter:masterfrom
kenzieschmoll:polish2
Apr 4, 2025
Merged

kenzieschmoll merged 2 commits into
flutter:masterfrom
kenzieschmoll:polish2

Conversation

@kenzieschmoll

Copy link
Copy Markdown
Member

Fixes #4924. Lands the changes from #8858.

@kenzieschmoll
kenzieschmoll requested a review from bkonyi as a code owner April 3, 2025 17:44
// Note: this could be refactored to use a single [GaDevToolsButton] instead
// of a [RoundedButtonGroup] with only one child, but this would require
// changes to the underlying [DevToolsButton] widget from
// package:devtools_app_shared to accept an `iconAsset` as a parameter.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this worth filing an issue for?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a note instead of a TODO per our discussion at the DevExp kick off meeting. I think this would be an issue filed that never becomes important enough to address, so I opted to leave a note instead of filing an issue since addressing this is unimportant.

@kenzieschmoll
kenzieschmoll merged commit 8544918 into flutter:master Apr 4, 2025
@kenzieschmoll
kenzieschmoll deleted the polish2 branch April 4, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combine resume / pause to one button to save screen space.

3 participants