Repository navigation
Fix benchmark test failures erroneously passing on CI - #9403
Merged
Merged
Conversation
elliette
changed the title
elliette
changed the title
elliette
marked this pull request as ready for review
October 14, 2025 20:33
elliette
requested review from
srawlins
and removed request for
kenzieschmoll
October 14, 2025 20:42
srawlins
approved these changes
Oct 14, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #9397
Unfortunately it will be impossible to verify if this fixed the issue of our benchmark tests erroneously passing on CI because we are only seeing that behavior on commits to the
masterbranch, and not to commits to an open PR.My best guess here is that the redundant
-jarg (with invalid,) value is causing issues here.-jis the short name for the--concurrencyflag. Note: I'm guessing this was simply a copy-paste error when copying the flag fromflutter test --help:-j, --concurrency=<jobs> The number of concurrent test processes to run. This will be ignored when running integration tests.