Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[win32] support high frame rates - #28927

Merged
fluttergithubbot merged 7 commits into
flutter-team-archive:mainfrom
jonahwilliams:windows-frame-rate
Mar 3, 2022
Merged

fluttergithubbot merged 7 commits into
flutter-team-archive:mainfrom
jonahwilliams:windows-frame-rate

Conversation

@jonahwilliams

@jonahwilliams jonahwilliams commented Sep 29, 2021 •

Copy link
Copy Markdown
Contributor

On the win32 embedding, asking dwm for the frame rate and use this to schedule frames instead of only using 60 hz. For UWP this remains 60 hz.

Increase the default timer resolution for win 10 and greater. I think this restriction could be loosened a bit in the future, but this is a fairly conservative choice.

@google-cla google-cla Bot added the cla: yes label Sep 29, 2021
@jonahwilliams
jonahwilliams force-pushed the windows-frame-rate branch 2 times, most recently from e564e54 to 9bfb84f Compare September 29, 2021 15:23
@jonahwilliams
jonahwilliams marked this pull request as ready for review September 29, 2021 16:10
@CaseyHillers
CaseyHillers changed the base branch from master to main November 15, 2021 18:16
@godofredoc
godofredoc changed the base branch from master to main November 24, 2021 07:18
@flutter-dashboard

Copy link
Copy Markdown

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

@dnfield dnfield left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

Comment thread fml/platform/win/message_loop_win.cc Outdated
Comment on lines +12 to +13
const uint32_t kHighResolutionTimer = 1; // 1 ms
const uint32_t kLowResolutionTimer = 15; // 15 ms

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constexpr

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jonahwilliams jonahwilliams added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 3, 2022
@fluttergithubbot
fluttergithubbot merged commit 5fc1469 into flutter-team-archive:main Mar 3, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 3, 2022
@clarkezone

Copy link
Copy Markdown

AWESOME!

@jonahwilliams
jonahwilliams deleted the windows-frame-rate branch March 5, 2022 05:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes platform-windows waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Development

Successfully merging this pull request may close these issues.

4 participants