Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[ci.yaml] Move roller to cocoon scheduler - #31679

Merged
fluttergithubbot merged 1 commit into
mainfrom
CaseyHillers-patch-2
Feb 25, 2022
Merged

[ci.yaml] Move roller to cocoon scheduler#31679
fluttergithubbot merged 1 commit into
mainfrom
CaseyHillers-patch-2

Conversation

@CaseyHillers

@CaseyHillers CaseyHillers commented Feb 25, 2022

Copy link
Copy Markdown
Contributor

flutter/flutter#92300

For the engine, this is a no-op since this is marked in bringup. However, it'll let us validate the copybara mirrors

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

keyonghan
keyonghan approved these changes Feb 25, 2022
View reviewed changes

@keyonghan keyonghan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers mentioned this pull request Feb 25, 2022
Merged
7 of 8 tasks
@CaseyHillers CaseyHillers added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 25, 2022
@fluttergithubbot
fluttergithubbot merged commit b5dd0a4 into main Feb 25, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 26, 2022
@engine-flutter-autoroll
b5dd0a4 [ci.yaml] Move roller to cocoon scheduler (flutter-team-archi…
458fe66 
…ve/engine#31679)
@cbracken
cbracken deleted the CaseyHillers-patch-2 branch May 27, 2022 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@godofredoc godofredoc Awaiting requested review from godofredoc
1 more reviewer
@keyonghan keyonghan keyonghan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CaseyHillers @keyonghan @fluttergithubbot