This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Repository navigation
Include checkbox in check state update - #35557
Merged
yaakovschectman merged 6 commits intoAug 22, 2022
Merged
yaakovschectman merged 6 commits into
yaakovschectman merged 6 commits into
Conversation
cbracken
reviewed
Aug 20, 2022
loic-sharma
reviewed
Aug 20, 2022
cbracken
reviewed
Aug 20, 2022
yaakovschectman
force-pushed
the
windows_checkbox_a11y
branch
from
August 22, 2022 17:35
77cd1c3 to
b3a305d
Compare
yaakovschectman
force-pushed
the
windows_checkbox_a11y
branch
from
August 22, 2022 18:06
40756e4 to
2656be0
Compare
yaakovschectman
marked this pull request as ready for review
August 22, 2022 18:07
cbracken
approved these changes
Aug 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the accessibility semantics for Checkboxes on Windows platform applications did not update when the state (checked/unchecked) of the widget changed. It seems to me that this was the result of an overly-restrictive check that only propagated updates to this status for Radio widgets, excluding Checkboxes. That is fixed in this PR and a unit test is added to ensure that state changes to Checkboxes are properly reflected.
Addresses issue flutter/flutter#96218 in the Flutter repo.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.