Repository navigation
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I'll follow up in the Pigeon PR, but I don't think this is the right avenue here; the documentation for this class is "Thrown to indicate that a Flutter method invocation failed on the Flutter side", and you are trying to repurpose it for the opposite. |
2 participants
The default constructor access modifier in java is package-private, which restricts access outside of this package
Change the constructor to
publicso that others may construct their ownFlutterException