Skip to content

Commit 33b402d

Browse files
bkonyibkonyi
authored
Reland "Launch DDS from Dart SDK and prepare to serve DevTools from DDS (#146593)" (#152386)
This reverts commit 7cdc23b. The failure in the `native_assets_test` integration test on Windows was caused by the DevTools process not being shutdown by the `ColdRunner` when running the profile mode portion of the test. This resulted in the test being unable to clean up the project created by the test as DevTools was still holding onto a handle within the directory. This PR adds back the mistakenly removed DevTools shutdown logic in the `ColdRunner`.
1 parent 3a737c9 commit 33b402d

57 files changed

Lines changed: 785 additions & 747 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎packages/flutter_tools/lib/src/android/android_device.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class AndroidDevice extends Device {
5959
this.productID,
6060
required this.modelID,
6161
this.deviceCodeName,
62-
required Logger logger,
62+
required super.logger,
6363
required ProcessManager processManager,
6464
required Platform platform,
6565
required AndroidSdk androidSdk,

0 commit comments

Comments
 (0)