Skip to content

Commit 678da3a

Browse files
author
Dan Rubel
authored
cancel open subscription (#5824)
fixes #5788
1 parent 4ea8f30 commit 678da3a

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

‎.analysis_options‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ linter:
3838
# === error rules ===
3939
- avoid_empty_else
4040
# - comment_references # blocked on https://github.com/dart-lang/dartdoc/issues/1153
41-
# - cancel_subscriptions # https://github.com/flutter/flutter/issues/5788
41+
- cancel_subscriptions
4242
# - close_sinks # https://github.com/flutter/flutter/issues/5789
4343
- control_flow_in_finally
4444
- empty_statements

‎.analysis_options_flutter_analyze‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ linter:
3939
# === error rules ===
4040
- avoid_empty_else
4141
# - comment_references # blocked on https://github.com/dart-lang/dartdoc/issues/1153
42-
# - cancel_subscriptions # https://github.com/flutter/flutter/issues/5788
42+
- cancel_subscriptions
4343
# - close_sinks # https://github.com/flutter/flutter/issues/5789
4444
- control_flow_in_finally
4545
- empty_statements

‎packages/flutter_tools/lib/src/base/process.dart‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ Future<int> runCommandAndStreamOutput(List<String> cmd, {
7878
// Wait for stdout to be fully processed
7979
// because process.exitCode may complete first causing flaky tests.
8080
await subscription.asFuture();
81+
subscription.cancel();
8182

8283
return await process.exitCode;
8384
}

0 commit comments

Comments
 (0)