Repository navigation
Commit f80ff55
authored
Fix for endless recursion for getLayoutExplorerNode on a Tooltip (#131486)

Fixes flutter/devtools#5946
While preparing DevTools for the Multi View changes, I noticed that
inspecting a Tooltip causes an stack overflow.
This PR addresses that issue by fixing the scope of the subtreeDepth variable and adding some other idiomatic fixes1 parent dc4ab0f commit f80ff55
2 files changed
Lines changed: 64 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2109 | 2109 | | |
2110 | 2110 | | |
2111 | 2111 | | |
2112 | | - | |
| 2112 | + | |
| 2113 | + | |
2113 | 2114 | | |
2114 | | - | |
| 2115 | + | |
| 2116 | + | |
2115 | 2117 | | |
2116 | 2118 | | |
2117 | 2119 | | |
2118 | 2120 | | |
2119 | | - | |
| 2121 | + | |
| 2122 | + | |
2120 | 2123 | | |
2121 | 2124 | | |
2122 | 2125 | | |
2123 | 2126 | | |
2124 | 2127 | | |
2125 | | - | |
| 2128 | + | |
| 2129 | + | |
| 2130 | + | |
| 2131 | + | |
| 2132 | + | |
| 2133 | + | |
| 2134 | + | |
2126 | 2135 | | |
2127 | 2136 | | |
2128 | 2137 | | |
2129 | | - | |
| 2138 | + | |
| 2139 | + | |
| 2140 | + | |
2130 | 2141 | | |
2131 | 2142 | | |
2132 | 2143 | | |
| |||
2147 | 2158 | | |
2148 | 2159 | | |
2149 | 2160 | | |
2150 | | - | |
| 2161 | + | |
2151 | 2162 | | |
2152 | 2163 | | |
2153 | 2164 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4771 | 4771 | | |
4772 | 4772 | | |
4773 | 4773 | | |
| 4774 | + | |
| 4775 | + | |
| 4776 | + | |
| 4777 | + | |
| 4778 | + | |
| 4779 | + | |
| 4780 | + | |
| 4781 | + | |
| 4782 | + | |
| 4783 | + | |
| 4784 | + | |
| 4785 | + | |
| 4786 | + | |
| 4787 | + | |
| 4788 | + | |
| 4789 | + | |
| 4790 | + | |
| 4791 | + | |
| 4792 | + | |
| 4793 | + | |
| 4794 | + | |
| 4795 | + | |
| 4796 | + | |
| 4797 | + | |
| 4798 | + | |
| 4799 | + | |
| 4800 | + | |
| 4801 | + | |
| 4802 | + | |
| 4803 | + | |
| 4804 | + | |
| 4805 | + | |
| 4806 | + | |
| 4807 | + | |
| 4808 | + | |
| 4809 | + | |
| 4810 | + | |
| 4811 | + | |
| 4812 | + | |
| 4813 | + | |
| 4814 | + | |
| 4815 | + | |
| 4816 | + | |
| 4817 | + | |
| 4818 | + | |
| 4819 | + | |
| 4820 | + | |
4774 | 4821 | | |
4775 | 4822 | | |
4776 | 4823 | | |
| |||
0 commit comments