Repository navigation
Comparing changes
Open a pull request
base repository: flutter/flutter
base: 54de32d6e159
head repository: flutter/flutter
compare: 336a7ecf7b40
- 19 commits
- 45 files changed
- 15 contributors
Commits on May 12, 2025
-
Roll Skia from 9f9e1f37917e to c97451da059f (1 revision) (#168671)
https://skia.googlesource.com/skia.git/+log/9f9e1f37917e..c97451da059f 2025-05-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 722efac - Browse repository at this point
Copy the full SHA 722efacView commit details -
Configuration menu - View commit details
-
Copy full SHA for c99de24 - Browse repository at this point
Copy the full SHA c99de24View commit details -
Roll Packages from 7814fab to 6a28ad9 (2 revisions) (#168669)
flutter/packages@7814fab...6a28ad9 2025-05-11 [email protected] Roll Flutter from 83082c1 to 992ad74 (17 revisions) (flutter/packages#9239) 2025-05-09 [email protected] Roll Flutter from 02d8c1a to 83082c1 (6 revisions) (flutter/packages#9232) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 0203084 - Browse repository at this point
Copy the full SHA 0203084View commit details -
Label platform view modes using the unified naming scheme (#168670)
Stop referring to TLHC as the newest platform view mode and label the controllers with what modes they are used for. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
Configuration menu - View commit details
-
Copy full SHA for dd94ba4 - Browse repository at this point
Copy the full SHA dd94ba4View commit details -
Remove CupertinoSliverNavigationBar background box when large title i…
…s extended (#168407) ### Before https://github.com/user-attachments/assets/436e49a7-015b-4383-9670-11917945c659 ### After https://github.com/user-attachments/assets/6ea5aaa3-7d9f-42be-969b-a03119c8c0d8 ### Native https://github.com/user-attachments/assets/7b8c0f5d-9b72-48b6-8ec5-6c994c24a4ad Fixes [CupertinoSliverNavigationBar with extended large title doesn't have a transparent background with transitionBetweenRoutes](#168406)
Configuration menu - View commit details
-
Copy full SHA for 00dc13b - Browse repository at this point
Copy the full SHA 00dc13bView commit details -
Add test for stack trace mapping and test expression eval tests using…
… DDC library bundle format (#168017) The bootstrap script utilizes a DDC utility function that maps paths to their module name in order for the stack traces to show the Dart paths and not the JS paths. This gets utilized in some stack tracing functionalities like StackTrace.current. We should test that the mapping is correct and we expect the correct stack traces. These tests should be run with the DDC library bundle format as well, so refactors them into shared code. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. ---- Once we have the CL to emit inlined source maps for the DDC library bundle format landed, we can fork this test and run it with that format as well.
Configuration menu - View commit details
-
Copy full SHA for 2871340 - Browse repository at this point
Copy the full SHA 2871340View commit details -
Nav bar back label is not clipped mid-transition (#168194)
### Before https://github.com/user-attachments/assets/fe354e67-c36d-4ce6-bf0f-0ca559962bfd ### After https://github.com/user-attachments/assets/e57b91a0-00ed-493a-92b4-549dc8ab330a Fixes [CupertinoNavigationBar flickers when previousPageTitle more than 4 characters](#149905)
Configuration menu - View commit details
-
Copy full SHA for b772c17 - Browse repository at this point
Copy the full SHA b772c17View commit details -
Error when trying to use old HC mode when HCPP is enabled (#168027)
Fixes #164218. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 88ce956 - Browse repository at this point
Copy the full SHA 88ce956View commit details -
[Impeller] libImpeller: Allow setting text decorations. (#168408)
Underlines, overlines, strikethroughs (with dashed, wavy, dotted... styles) etc.. Fixes #157796 <img width="1136" alt="Screenshot 2025-05-06 at 1 04 30 PM" src="https://github.com/user-attachments/assets/f2233ebd-87b2-42ca-ac2a-c71e40ceb953" />
Configuration menu - View commit details
-
Copy full SHA for ed60ea9 - Browse repository at this point
Copy the full SHA ed60ea9View commit details -
Roll Dart SDK from 0bea6379f654 to 645d04a7a964 (14 revisions) (#168679)
https://dart.googlesource.com/sdk.git/+log/0bea6379f654..645d04a7a964 2025-05-12 [email protected] Version 3.9.0-114.0.dev 2025-05-12 [email protected] Version 3.9.0-113.0.dev 2025-05-12 [email protected] Version 3.9.0-112.0.dev 2025-05-11 [email protected] Version 3.9.0-111.0.dev 2025-05-10 [email protected] Version 3.9.0-110.0.dev 2025-05-10 [email protected] Version 3.9.0-109.0.dev 2025-05-09 [email protected] Version 3.9.0-108.0.dev 2025-05-09 [email protected] Version 3.9.0-107.0.dev 2025-05-09 [email protected] Version 3.9.0-106.0.dev 2025-05-09 [email protected] Version 3.9.0-105.0.dev 2025-05-09 [email protected] Version 3.9.0-104.0.dev 2025-05-08 [email protected] Version 3.9.0-103.0.dev 2025-05-08 [email protected] Version 3.9.0-102.0.dev 2025-05-08 [email protected] Version 3.9.0-101.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 2982c93 - Browse repository at this point
Copy the full SHA 2982c93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47d1e39 - Browse repository at this point
Copy the full SHA 47d1e39View commit details -
Android home/end keyboard shortcut support (#168184)
This PR adds support for Home and End keyboard shortcuts on Android. It seems like we had mistakenly purposely disabled them on Android before (or maybe native Android recently added support for them?). In the process I also noticed that Linux was missing home/end+control shortcuts, so I added them. I confirmed that these are supported natively using my Linux machine. Fixes #168183
Configuration menu - View commit details
-
Copy full SHA for 4ccfa07 - Browse repository at this point
Copy the full SHA 4ccfa07View commit details -
Fix DropdownButtonFormField icon not vertically centered (#163205)
## Description This PR fixes `DropdownButtonFormField` suffix icon vertical alignment when `DropdownButtonFormField.inputDecoration` is provided without a hint text. ### Before: The dropdown icon is misaligned vertically:  ### After: The dropdown icon is aligned vertically:  ## Related Issue Fixes [DropdownButtonFormField arrow icon is misaligned vertically](#157074) ## Tests Adds 1 test.
Configuration menu - View commit details
-
Copy full SHA for 81de9ed - Browse repository at this point
Copy the full SHA 81de9edView commit details -
Roll ICU from c9fb4b3a6fb5 to b929596baebf (5 revisions) (#168691)
https://chromium.googlesource.com/chromium/deps/icu.git/+log/c9fb4b3a6fb5..b929596baebf 2025-05-05 [email protected] Revert "Suppress -Wunnecessary-virtual-specifier on Fuchsia" 2025-05-05 [email protected] Cherrypick ICU PR3489 Remove unnecessary virtual specifiers 2025-04-29 [email protected] Update arm_control_flow_integrity to use bti+pac-ret 2025-04-22 [email protected] Updated tzdb from 2025a to 2025b 2025-04-02 [email protected] Suppress -Wunnecessary-virtual-specifier on Fuchsia If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/icu-sdk-flutter Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in ICU: https://github.com/unicode-org/icu To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 0fb5da1 - Browse repository at this point
Copy the full SHA 0fb5da1View commit details -
Make the barrier panel on the Material Drawer non-dismissible (#164810)
This PR entails making the modal barrier behind the Material Drawer dismissible / non-dismissible via a Scaffold flag named "drawerBarrierDismissible", as in: ``` Scaffold( drawerBarrierDismissible: false, // defaults to true so it behaves as normal .... ) ``` This is so as to force the Drawer to be opened / closed programmatically using either: ``` Scaffold.of(context).openEndDrawer() / openDrawer() ``` or ``` Scaffold.of(Utils.adminNav.currentContext!).closeDrawer() / closeEndDrawer() ``` and the user not closing the Drawer upon tapping on the modal barrier. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. --------- Co-authored-by: Tong Mu <[email protected]> Co-authored-by: Justin McCandless <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5c80840 - Browse repository at this point
Copy the full SHA 5c80840View commit details
Commits on May 13, 2025
-
Roll Fuchsia Linux SDK from 6vjKe0bfYDVaECqBL... to 6J81agNhuK4q255Jj…
…... (#168712) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 149ac49 - Browse repository at this point
Copy the full SHA 149ac49View commit details -
Tab bar theme and dialog theme documentation cleanup (#168724)
## Description While preparing a PR to normalize `InputDecorationTheme` (part of #91772), I spotted some typos in tab bar theme and dialog theme documentation: ## Tests Documentation only
Configuration menu - View commit details
-
Copy full SHA for 1acb89f - Browse repository at this point
Copy the full SHA 1acb89fView commit details -
Fixed Android Lint Errors (#168613)
Fixes blocking warnings on Flutter Roll. Also should fix red tree. Had to add `@RequiresApi` annotations at the function level due to usage and requirements of Android functions. This happened because I removed `@TargetApi` at the class level due to conflicts within the class. It seems that the `@TargetApi` annotation can no longer be used. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for 358b072 - Browse repository at this point
Copy the full SHA 358b072View commit details -
Add assert for index parameter in IndexedStack. (#167757)
<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> Closes #165840 by adding an assert with a more user-friendly message to the IndexedStack. ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Configuration menu - View commit details
-
Copy full SHA for 336a7ec - Browse repository at this point
Copy the full SHA 336a7ecView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 54de32d6e159...336a7ecf7b40