Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 54de32d6e159
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 336a7ecf7b40
Choose a head ref
  • 19 commits
  • 45 files changed
  • 15 contributors

Commits on May 12, 2025

  1. Roll Skia from 9f9e1f37917e to c97451da059f (1 revision) (#168671)

    https://skia.googlesource.com/skia.git/+log/9f9e1f37917e..c97451da059f
    
    2025-05-12
    recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com
    Roll recipe dependencies (trivial).
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected] on
    the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 12, 2025
    Configuration menu
    Copy the full SHA
    722efac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c99de24 View commit details
    Browse the repository at this point in the history
  3. Roll Packages from 7814fab to 6a28ad9 (2 revisions) (#168669)

    flutter/packages@7814fab...6a28ad9
    
    2025-05-11 [email protected] Roll Flutter from
    83082c1 to 992ad74 (17 revisions) (flutter/packages#9239)
    2025-05-09 [email protected] Roll Flutter from
    02d8c1a to 83082c1 (6 revisions) (flutter/packages#9232)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected] on the revert to ensure that a
    human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 12, 2025
    Configuration menu
    Copy the full SHA
    0203084 View commit details
    Browse the repository at this point in the history
  4. Label platform view modes using the unified naming scheme (#168670)

    Stop referring to TLHC as the newest platform view mode and label the
    controllers with what modes they are used for.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    reidbaker authored May 12, 2025
    Configuration menu
    Copy the full SHA
    dd94ba4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    00dc13b View commit details
    Browse the repository at this point in the history
  6. Add test for stack trace mapping and test expression eval tests using…

    … DDC library bundle format (#168017)
    
    The bootstrap script utilizes a DDC utility function that maps paths to
    their module name in order for the stack traces to show the Dart paths
    and not the JS paths. This gets utilized in some stack tracing
    functionalities like StackTrace.current. We should test that the mapping
    is correct and we expect the correct stack traces.
    
    These tests should be run with the DDC library bundle format as well, so
    refactors them into shared code.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    ----
    
    Once we have the CL to emit inlined source maps for the DDC library
    bundle format landed, we can fork this test and run it with that format
    as well.
    srujzs authored May 12, 2025
    Configuration menu
    Copy the full SHA
    2871340 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b772c17 View commit details
    Browse the repository at this point in the history
  8. Error when trying to use old HC mode when HCPP is enabled (#168027)

    Fixes #164218.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    
    ---------
    
    Co-authored-by: Gray Mackall <[email protected]>
    gmackall and mackall-work authored May 12, 2025
    Configuration menu
    Copy the full SHA
    88ce956 View commit details
    Browse the repository at this point in the history
  9. [Impeller] libImpeller: Allow setting text decorations. (#168408)

    Underlines, overlines, strikethroughs (with dashed, wavy, dotted...
    styles) etc..
    
    Fixes #157796
    
    <img width="1136" alt="Screenshot 2025-05-06 at 1 04 30 PM"
    src="https://github.com/user-attachments/assets/f2233ebd-87b2-42ca-ac2a-c71e40ceb953"
    />
    chinmaygarde authored May 12, 2025
    Configuration menu
    Copy the full SHA
    ed60ea9 View commit details
    Browse the repository at this point in the history
  10. Roll Dart SDK from 0bea6379f654 to 645d04a7a964 (14 revisions) (#168679)

    https://dart.googlesource.com/sdk.git/+log/0bea6379f654..645d04a7a964
    
    2025-05-12 [email protected]
    Version 3.9.0-114.0.dev
    2025-05-12 [email protected]
    Version 3.9.0-113.0.dev
    2025-05-12 [email protected]
    Version 3.9.0-112.0.dev
    2025-05-11 [email protected]
    Version 3.9.0-111.0.dev
    2025-05-10 [email protected]
    Version 3.9.0-110.0.dev
    2025-05-10 [email protected]
    Version 3.9.0-109.0.dev
    2025-05-09 [email protected]
    Version 3.9.0-108.0.dev
    2025-05-09 [email protected]
    Version 3.9.0-107.0.dev
    2025-05-09 [email protected]
    Version 3.9.0-106.0.dev
    2025-05-09 [email protected]
    Version 3.9.0-105.0.dev
    2025-05-09 [email protected]
    Version 3.9.0-104.0.dev
    2025-05-08 [email protected]
    Version 3.9.0-103.0.dev
    2025-05-08 [email protected]
    Version 3.9.0-102.0.dev
    2025-05-08 [email protected]
    Version 3.9.0-101.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter
    Please CC [email protected],[email protected] on the revert to
    ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 12, 2025
    Configuration menu
    Copy the full SHA
    2982c93 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    47d1e39 View commit details
    Browse the repository at this point in the history
  12. Android home/end keyboard shortcut support (#168184)

    This PR adds support for Home and End keyboard shortcuts on Android. It
    seems like we had mistakenly purposely disabled them on Android before
    (or maybe native Android recently added support for them?).
    
    In the process I also noticed that Linux was missing home/end+control
    shortcuts, so I added them. I confirmed that these are supported
    natively using my Linux machine.
    
    Fixes #168183
    justinmc authored May 12, 2025
    Configuration menu
    Copy the full SHA
    4ccfa07 View commit details
    Browse the repository at this point in the history
  13. Fix DropdownButtonFormField icon not vertically centered (#163205)

    ## Description
    
    This PR fixes `DropdownButtonFormField` suffix icon vertical alignment
    when `DropdownButtonFormField.inputDecoration` is provided without a
    hint text.
    
    ### Before:
    
    The dropdown icon is misaligned vertically:
    
    
    ![image](https://github.com/user-attachments/assets/b79b35ae-c333-4cb4-91f7-5c9ce8edd975)
    
    
    ### After:
    
    The dropdown icon is aligned vertically:
    
    
    ![image](https://github.com/user-attachments/assets/b5704453-66a3-4cb2-97ff-bef556bff377)
    
    
    ## Related Issue
    
    Fixes [DropdownButtonFormField arrow icon is misaligned
    vertically](#157074)
    
    ## Tests
    
    Adds 1 test.
    bleroux authored May 12, 2025
    Configuration menu
    Copy the full SHA
    81de9ed View commit details
    Browse the repository at this point in the history
  14. Roll ICU from c9fb4b3a6fb5 to b929596baebf (5 revisions) (#168691)

    https://chromium.googlesource.com/chromium/deps/icu.git/+log/c9fb4b3a6fb5..b929596baebf
    
    2025-05-05 [email protected] Revert "Suppress
    -Wunnecessary-virtual-specifier on Fuchsia"
    2025-05-05 [email protected] Cherrypick ICU PR3489 Remove unnecessary
    virtual specifiers
    2025-04-29 [email protected] Update arm_control_flow_integrity to
    use bti+pac-ret
    2025-04-22 [email protected] Updated tzdb from 2025a to  2025b
    2025-04-02 [email protected] Suppress -Wunnecessary-virtual-specifier
    on Fuchsia
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/icu-sdk-flutter
    Please CC [email protected],[email protected] on the
    revert to ensure that a human
    is aware of the problem.
    
    To file a bug in ICU: https://github.com/unicode-org/icu
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 12, 2025
    Configuration menu
    Copy the full SHA
    0fb5da1 View commit details
    Browse the repository at this point in the history
  15. Make the barrier panel on the Material Drawer non-dismissible (#164810)

    This PR entails making the modal barrier behind the Material Drawer
    dismissible / non-dismissible via a Scaffold flag named
    "drawerBarrierDismissible", as in:
    
    ```
    Scaffold(
       drawerBarrierDismissible: false, // defaults to true so it behaves as normal
       ....
    )
    ```
    
    This is so as to force the Drawer to be opened / closed programmatically
    using either:
    
    ```
    Scaffold.of(context).openEndDrawer() / openDrawer()
    ```
    
    or 
    
    ```
    Scaffold.of(Utils.adminNav.currentContext!).closeDrawer() / closeEndDrawer()
    ```
    
    and the user not closing the Drawer upon tapping on the modal barrier. 
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    ---------
    
    Co-authored-by: Tong Mu <[email protected]>
    Co-authored-by: Justin McCandless <[email protected]>
    3 people authored May 12, 2025
    Configuration menu
    Copy the full SHA
    5c80840 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2025

  1. Roll Fuchsia Linux SDK from 6vjKe0bfYDVaECqBL... to 6J81agNhuK4q255Jj…

    …... (#168712)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
    Please CC [email protected],[email protected] on the revert to ensure
    that a human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored May 13, 2025
    Configuration menu
    Copy the full SHA
    149ac49 View commit details
    Browse the repository at this point in the history
  2. Tab bar theme and dialog theme documentation cleanup (#168724)

    ## Description
    
    While preparing a PR to normalize `InputDecorationTheme` (part of
    #91772), I spotted some typos
    in tab bar theme and dialog theme documentation:
    
    ## Tests
    
    Documentation only
    bleroux authored May 13, 2025
    Configuration menu
    Copy the full SHA
    1acb89f View commit details
    Browse the repository at this point in the history
  3. Fixed Android Lint Errors (#168613)

    Fixes blocking warnings on Flutter Roll. Also should fix red tree.
    
    Had to add `@RequiresApi` annotations at the function level due to usage
    and requirements of Android functions. This happened because I removed
    `@TargetApi` at the class level due to conflicts within the class. It
    seems that the `@TargetApi` annotation can no longer be used.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    jesswrd authored May 13, 2025
    Configuration menu
    Copy the full SHA
    358b072 View commit details
    Browse the repository at this point in the history
  4. Add assert for index parameter in IndexedStack. (#167757)

    <!--
    Thanks for filing a pull request!
    Reviewers are typically assigned within a week of filing a request.
    To learn more about code review, see our documentation on Tree Hygiene:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    -->
    
    Closes #165840 by adding an
    assert with a more user-friendly message to the IndexedStack.
    
    ## Pre-launch Checklist
    
    - [X] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [X] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [X] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [X] I signed the [CLA].
    - [X] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [X] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [X] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [X] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    ksokolovskyi authored May 13, 2025
    Configuration menu
    Copy the full SHA
    336a7ec View commit details
    Browse the repository at this point in the history
Loading