Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 864d4f59dde0
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 72db8f69e339
Choose a head ref
  • 11 commits
  • 106 files changed
  • 10 contributors

Commits on Jan 10, 2025

  1. Configuration menu
    Copy the full SHA
    ee4d46d View commit details
    Browse the repository at this point in the history
  2. 🔊 [tool] Add a wirelessly connected device name as displayName (#16…

    …0497)
    
    An improvement for #144634.
    
    A wirelessly connected device will displayed as `Target device 1
    (wireless)` in various of places.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    AlexV525 authored Jan 10, 2025
    Configuration menu
    Copy the full SHA
    771b8a4 View commit details
    Browse the repository at this point in the history
  3. Update TextEditingController.text documentation to recommend agains…

    …t using it in production code (#157769)
    
    The `TextEditingController.text` setter has been a major source of
    confusion, as using it would usually result in loss of cursor position
    if the text field is active. Arguably it also should not be part of the
    controller's interface since it is a convenience method.
    
    There are many issues, for example:
    #65547
    
    
    ## Pre-launch Checklist
    
    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [ ] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    LongCatIsLooong authored Jan 10, 2025
    Configuration menu
    Copy the full SHA
    9e211ca View commit details
    Browse the repository at this point in the history
  4. CupertinoSheetRoute (#157568)

    Fixes #42560
    
    ### Updated 12/04/24
    
    Adds a CupertinoSheetRoute which displays an iOS style sheet, while
    giving the previous route a delegated transition to sync up correctly.
    
    There's a lot of sample files in this draft showing different use cases
    for the sake of reviewing the PR. We'll want to probably go down to
    about two before this PR lands.
    
    **TODO in this PR**
    
    - [x] Write actual documentation
    - [x] Write tests
    
    **TODO in a feature branch, and will be merged with this PR**
    
    - [ ] Add swipe down to dismiss
    
    **TODO in a follow up PR**
    
    - [ ] Stretching on swipe up
    - [ ] Add a fullscreen version
    - [x] Dark mode theming
    
    How it currently compares, with the simple case and nested navigation:
    | Flutter  | Native|
    | ------------- | ------------- |
    |
    ![Flutter-Simple](https://github.com/user-attachments/assets/2a1f277e-91c9-48e0-b894-5fad71ef6a21)
    |![Native-Simple](https://github.com/user-attachments/assets/6960252a-f762-4ad8-8d68-5c3d7cf8d4e7)
    |
    |
    ![Flutter-Nested](https://github.com/user-attachments/assets/bacb3e35-9d11-4113-9331-75daaded67e7)
    |
    ![Native-stacked](https://github.com/user-attachments/assets/70ccbbbb-24c2-40b5-b838-4f8412828b9b)
    |
    
    Update:
    
    ![Flutter-Status-Bar](https://github.com/user-attachments/assets/c738cc5c-7176-4df2-9422-6b3fa608c943)
    Now the status bar will transition from dark to light text so that it's
    visible after the transition.
    
    `cupertino_sheet.0.dart` has an example of what it looks like to do a
    simple case. It's fairly straightforward.
    
    `cupertino_sheet.1.dart` shows one with nested navigation. It's
    necessary to add a `Navigator` if showing page navigation within the
    sheet is wanted. I'm thinking adding an API option that auto sets this
    up may be needed as there are some pitfalls.
    
    `cupertino_sheet.2.dart` functionally does the same as above but uses
    the `showCupertinoSheet` to reduce boilerplate.
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [x] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    MitchellGoodwin authored Jan 10, 2025
    Configuration menu
    Copy the full SHA
    50f7120 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2025

  1. add semantics role and tab (#161260)

    fixes #157134
    
    ## Pre-launch Checklist
    
    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [ ] I signed the [CLA].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    chunhtai authored Jan 11, 2025
    Configuration menu
    Copy the full SHA
    6b8b579 View commit details
    Browse the repository at this point in the history
  2. Remove some miscellaneous references to Cirrus. (#161390)

    Towards #161387.
    
    ... made a few TLC changes the best I could.
    matanlurey authored Jan 11, 2025
    Configuration menu
    Copy the full SHA
    00b6a4e View commit details
    Browse the repository at this point in the history
  3. [android_engine_test] Remove background/foreground from surface textu…

    …re trampoline test. (#161441)
    
    See if this fixes the golden. The background/foreground isn't necessary
    for this test which is just a gold comparison of the rendering
    Jonah Williams
    Jonah Williams authored Jan 11, 2025
    Configuration menu
    Copy the full SHA
    bd1ebf2 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2025

  1. Configuration menu
    Copy the full SHA
    d14140f View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2025

  1. Deprecate unused ButtonStyleButton.iconAlignment property (#160023)

    Fixes [Deprecate unused `ButtonStyleButton.iconAlignment`
    property](#159782)
    
    Refactor done in #158503 makes
    `ButtonStyleButton.iconAlignment` redundant. In this PR I'm marking it
    as deprecated without migration guide. However, it may possible to
    remove it altogether.
    
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    TahaTesser authored Jan 13, 2025
    Configuration menu
    Copy the full SHA
    1c147a2 View commit details
    Browse the repository at this point in the history
  2. Update error message for when leading/trailing width exceeds `ListTil…

    …e` width and add missing test (#161091)
    
    Fixes [ListTile Crashes When Width Is Reduced with Leading or Trailing
    Widgets](#159380)
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [x] I signed the [CLA].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [ ] I followed the [breaking change policy] and added [Data Driven
    Fixes] where supported.
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
    [Tree Hygiene]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
    [test-exempt]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
    [Discord]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
    [Data Driven Fixes]:
    https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
    TahaTesser authored Jan 13, 2025
    Configuration menu
    Copy the full SHA
    cef35e7 View commit details
    Browse the repository at this point in the history
  3. Roll Packages from 6554751 to 3c3bc68 (16 revisions) (#161515)

    flutter/packages@6554751...3c3bc68
    
    2025-01-11 49699333+dependabot[bot]@users.noreply.github.com
    [dependabot]: Bump the test-dependencies group across 2 directories with
    1 update (flutter/packages#8412)
    2025-01-11 49699333+dependabot[bot]@users.noreply.github.com
    [dependabot]: Bump org.json:json from 20241224 to 20250107 in
    /packages/in_app_purchase/in_app_purchase_android/example/android/app
    (flutter/packages#8411)
    2025-01-11 [email protected] Roll Flutter from
    4b23b81 to 864d4f5 (50 revisions) (flutter/packages#8408)
    2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
    [dependabot]: Bump org.json:json from 20240303 to 20250107 in
    /packages/in_app_purchase/in_app_purchase_android/android
    (flutter/packages#8413)
    2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
    [dependabot]: Bump org.json:json from 20241224 to 20250107 in
    /packages/in_app_purchase/in_app_purchase/example/android/app
    (flutter/packages#8410)
    2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
    [dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in
    /packages/pigeon/platform_tests/test_plugin/android
    (flutter/packages#8357)
    2025-01-10 [email protected] Fix dependabot test-dependencies group
    io.mockk regex (flutter/packages#8406)
    2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
    [shared_pref]: Bump androidx.datastore:datastore from 1.0.0 to 1.1.1 in
    /packages/shared_preferences/shared_preferences_android/android
    (flutter/packages#7306)
    2025-01-10 [email protected] [url_launcher_windows] Correct logging url
    (flutter/packages#8107)
    2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
    [dependabot]: Bump io.mockk:mockk from 1.13.13 to 1.13.14 in
    /packages/shared_preferences/shared_preferences_android/android
    (flutter/packages#8358)
    2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
    [dependabot]: Bump the androidx group across 3 directories with 1 update
    (flutter/packages#8329)
    2025-01-10 49699333+dependabot[bot]@users.noreply.github.com
    [dependabot]: Bump org.json:json from 20240303 to 20241224 in
    /packages/in_app_purchase/in_app_purchase_android/example/android/app
    (flutter/packages#8372)
    2025-01-10 [email protected] [url_launcher][web] Better support for
    semantics in the Link widget (flutter/packages#6711)
    2025-01-10 [email protected] [camera]:
    Activate leak testing for sub packages (flutter/packages#8353)
    2025-01-09 [email protected]
    [camera_android_camerax] Remove logic used to previously correct preview
    rotation (flutter/packages#8256)
    2025-01-09 [email protected] [go_router]
    Rephrases readme to better describe the current status
    (flutter/packages#8403)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
    Please CC [email protected] on the revert to ensure that a
    human
    is aware of the problem.
    
    To file a bug in Flutter:
    https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Jan 13, 2025
    Configuration menu
    Copy the full SHA
    72db8f6 View commit details
    Browse the repository at this point in the history
Loading