Skip to content

Inlining a SurfaceView in a PlatformView in a Flutter hierarchy should have an automated test #100669

Description

@xster

We need an integration test to cover cases like b/226467394

Activity

  1. added
    a: tests"flutter test", flutter_test, or one of our tests
    platform-androidAndroid applications specifically
    a: qualityA truly polished experience
    a: platform-viewsEmbedding Android/iOS views in Flutter apps
    c: tech-debtTechnical debt, code quality, testing, etc.
    on Mar 24, 2022
  2. blasten commented on Mar 24, 2022

    @blasten

    In this specific issue, SurfaceView is embedded in a Flutter app.
    SurfaceViews can't be drawn to a Canvas for the purpose of detecting what and where that view is rendered.

    https://github.com/flutter/flutter/tree/master/packages/integration_test#screenshots should be able to help here.

  3. blasten commented on Mar 24, 2022

    @blasten

    offline conversation with jreck: this needs to use UiAutomation#takeScreenshot(), and remove the status/navigation bars

  4. changed the title [-]Inlining a PlatformView in a Flutter hierarchy should have an automated test[/-] [+]Inlining a SurfaceView in a PlatformView in a Flutter hierarchy should have an automated test[/+] on Mar 24, 2022
  5. xster commented on Mar 24, 2022

    @xster
    MemberAuthor

    Understood. Thanks. I was wondering, since we seem to have a bunch of platform view tests in the engine already.

  6. blasten commented on Mar 24, 2022

    @blasten

    Closing in favor of #97853. That issue is tracking missing integration tests.

  7. github-actions commented on Apr 7, 2022

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. locked as resolved and limited conversation to collaborators on Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

a: platform-viewsEmbedding Android/iOS views in Flutter appsa: qualityA truly polished experiencea: tests"flutter test", flutter_test, or one of our testsc: tech-debtTechnical debt, code quality, testing, etc.customer: googleVarious Google teamsplatform-androidAndroid applications specifically

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions