_cachedBaselines not clear when relayout

@override
void markNeedsLayout() {
  if ((_cachedBaselines != null && _cachedBaselines!.isNotEmpty) ||
      (_cachedIntrinsicDimensions != null && _cachedIntrinsicDimensions!.isNotEmpty) ||
      (_cachedDryLayoutSizes != null && _cachedDryLayoutSizes!.isNotEmpty)) {
    // If we have cached data, then someone must have used our data.
    // Since the parent will shortly be marked dirty, we can forget that they
    // used the baseline and/or intrinsic dimensions. If they use them again,
    // then we'll fill the cache again, and if we get dirty again, we'll
    // notify them again.
    **_cachedBaselines?.clear();**
    _cachedIntrinsicDimensions?.clear();
    _cachedDryLayoutSizes?.clear();
    if (parent is RenderObject) {
      markParentNeedsLayout();
      return;
    }
  }
  super.markNeedsLayout();
}

_cachedBaselines only be cleared in markNeedsLayout，but i think it should also be cleared in layout（when parent relayout it,）

I'm writing a custom layout with RenderBox, this layout will use the baseline of the child element, when I change the size of the child element and re-layout it, I still get the old baseline. This is wrong. Child elements should recalculate the baseline based on the new self size.

@hackware1993

@hackware1993
Please provide flutter doctor -v, a complete runnable but minimal reproducible code sample along with expected vs actual result.

Thanks.

flutter version: v2.10.3 stable

@hackware1993

@hackware1993
Also a complete runnable but minimal reproducible code sample as requested earlier.

My temporary solution is to change the source code of the local flutter framework.

Keeping this open and labeling for further investigation from the team.

Repro Steps

1, Run the code on a desktop platform
2, Resize the app window
3, Observer the placeholder position

Expect

20220407_114446.mp4

Actual

20220407_114740.mp4

Code

import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';

void main() {
  runApp(MaterialApp(
    title: 'Issue report',
    home: BaselineUse(),
  ));
}

class BaselineUse extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('Issue report'),),
      body: Baseline(
        baseline: 0.0,
        baselineType: TextBaseline.alphabetic,
        child: Column(
          children: const [
            Expanded(
              child: MyWidget(
                child: Placeholder(),
              ),
            )
          ],
        ),
      ),
    );
  }
}

class MyWidget extends SingleChildRenderObjectWidget {
  const MyWidget({Key? key, required Widget child})
      : super(key: key, child: child);

  @override
  RenderObject createRenderObject(BuildContext context) {
    return RenderMyWidget();
  }
}

class RenderMyWidget extends RenderProxyBox {
  late Size boxSize;

  @override
  double? computeDistanceToActualBaseline(TextBaseline baseline) {
    if (hasSize) {
      return boxSize.height / 2.0;
    } else {
      return 0.0;
    }
  }

  @override
  void layout(Constraints constraints, {bool parentUsesSize = false}) {
    super.layout(constraints, parentUsesSize: parentUsesSize);
    boxSize = size;
  }
}

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

Navigation Menu

Repository navigation

_cachedBaselines not clear when relayout #101179

6 remaining items

Repro Steps

Expect

Actual

Code

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

_cachedBaselines not clear when relayout #101179

Description

Activity

hackware1993 commented on Apr 1, 2022

darshankawar commented on Apr 1, 2022

hackware1993 commented on Apr 1, 2022

darshankawar commented on Apr 1, 2022

hackware1993 commented on Apr 2, 2022

darshankawar commented on Apr 4, 2022

6 remaining items

xu-baolin commented on Apr 7, 2022

Repro Steps

Expect

Actual

Code

github-actions commented on May 20, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions