Skip to content

Inserting a TabBarSelection doesn't cause its descendants to rebuild #1017

Closed

Description

@HansMuller

Dynamically adding a TabBarSelection ancestor of a TabBar or a TabBarView will not cause the descendants to be rebuilt, which means that the TabBar and TabBarView will not automatically begin listening to the the TabBarSelection's performance. The problem generalizes to any TabBarSelection descendant that uses TabBarSelectionState.registerPerformanceListeners() to track the selection's performance.

It's not clear how to handle this. Does TabBarSelection need to walk its subtree and rebuild nodes that implement some "I am going to register performance listeners" marking interface?

See also: #1007

Activity

  1. Hixie commented on Dec 25, 2015

    @Hixie
    Contributor

    One option might be to have the selection announce its existence on initState.

  2. modified the milestone: on Feb 3, 2016
  3. Hixie commented on Jun 27, 2017

    @Hixie
    Contributor

    cc @HansMuller Is this even still relevant? I'm going to close this since we don't have a TabBarSelection anymore, but if this still makes sense in some way please reopen it.

  4. github-actions commented on Aug 16, 2021

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  5. locked as resolved and limited conversation to collaborators on Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions