[go_router] Prevent access to route when navigated to via a deep link #103659

Activity

1. darshankawar

   added

   in triagePresently being triaged by the triage teamPresently being triaged by the triage team

   p: first party

   packageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.

   c: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutter

   p: go_routerThe go_router packageThe go_router package

   c: new featureNothing broken; request for a new capabilityNothing broken; request for a new capability

   and removed

   in triagePresently being triaged by the triage teamPresently being triaged by the triage team

   on May 13, 2022
2. stuartmorgan-g

   added

   P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter project

   on May 17, 2022
3. chunhtai commented on May 19, 2022

   

   chunhtai

   on May 19, 2022

   Contributor

   More actions

   Can you explain more on your use case?
4. chunhtai

   added this to GoRouteron May 19, 2022
5. vimhead commented on May 20, 2022

   

   vimhead

   on May 20, 2022

   More actions

   By default, any deep link is mapped to route configuration, even if route is not supposed to be accessed through deeplink.
   I suppose OP wants to disable deep linking to some pages. @chunhtai
6. DamienMrtl commented on May 23, 2022

   

   DamienMrtl

   on May 23, 2022

   Author

   More actions

   @chunhtai Yes I'm using Flutter Web and I want some routes to be accessed only by the user navigating "in-app" and not by entering the URL directly. For now I'm manually setting the extra argument to true when navigating in app, so I can differentiate between deeplinks or user navigation.
7. chunhtai commented on May 23, 2022

   

   chunhtai

   on May 23, 2022

   Last edited by chunhtai

   Contributor

   More actions

   Thanks for explanation, I think instead of add a boolean to the state, we should have a more comprehensive API to handle Deeplink

   For example

   GoRouter(
     ....
     onDeepLink: (RouteInformation info) => ....
   )

   and by default , it will go through the regular parsing if this method is not provided

   👍React with 👍26Reacted by ankitparmar007, Iskander Shamsudinov, Robert Heim, Anton Stubenbord, bvoq, brendanatlifewise, Bram Musters, Acácio Veit Schneider, Philippe Dupuis, Berdrigue and 16 more
8. DamienMrtl commented on May 23, 2022

   

   DamienMrtl

   on May 23, 2022

   Author

   More actions

   @chunhtai It's a good idea yes, but maybe the function onDeepLink should also be supported on each GoRoute(...). So we don't have to do some complicated "if else" or "switch case" for each routes we want to intercept in the global onDeepLink function.

   👍React with 👍2Reacted by wang222222222 and MenaRaafat
9. horo99 commented on Jun 13, 2022

   

   horo99

   on Jun 13, 2022

   Last edited by horo99

   More actions

   @chunhtai I need this feature also.
   But it maybe more suitable with a wider concept rather than deeplink merely.
   The wider concept is preventing an access going forward.
   By the way, is there any other method to prevent an access?

   Thanks for explanation, I think instead of add a boolean to the state, we should have a more comprehensive API to handle Deeplink

   For example

   GoRouter(
     ....
     onDeepLink: (RouteInformation info) => ....
   )

   and by default , it will go through the regular parsing if this method is not provided
10. 13 remaining items

    Load more

11. chunhtai commented on Jul 21, 2023

    

    chunhtai

    on Jul 21, 2023

    Contributor

    More actions

    I think there are two steps to fix this issue

    1. https://github.com/flutter/packages/pull/4392/files
       This adds the ability to know whether a GoRouteState is a deeplink (by checking GoRouteState.uri.host and GoRouteState.uri.scheme)
    2. [go_router] Replace redirect with onEnter and onExit #102408
       The onenter and onexit should have more flexible api to decide whether to push page or doing other operation.

    👍React with 👍3Reacted by J, Ruud Brouwers and Damien M
12. darshankawar

    removed

    multiteam-retriage-candidate

    on Oct 25, 2023
13. Harris-Thomas commented on Oct 28, 2023

    

    Harris-Thomas

    on Oct 28, 2023

    More actions

    Hi, when is this scheduled to release ? I have the same requirement to restrict deeplink, without going through login page.

    👍React with 👍1Reacted by Linaks
14. ChopinDavid commented on Dec 15, 2023

    

    ChopinDavid

    on Dec 15, 2023

    More actions

    I think there are two steps to fix this issue

    1. https://github.com/flutter/packages/pull/4392/files
       This adds the ability to know whether a GoRouteState is a deeplink (by checking GoRouteState.uri.host and GoRouteState.uri.scheme)
    2. [go_router] Replace redirect with onEnter and onExit #102408
       The onenter and onexit should have more flexible api to decide whether to push page or doing other operation.

    You mention that you can tell whether a GoRouteState is a deep link by checking GoRouteState.uri.host and GoRouteState.uri.scheme. Both of these values are "" when I check them in the redirect, does this sound right?

    If so, the only way to tell if a state is a deep link or initiated from within the app is to add some extra denoting that it is not a deeplink, as others have suggested?
15. ChopinDavid commented on Dec 17, 2023

    

    ChopinDavid

    on Dec 17, 2023

    Last edited by ChopinDavid

    More actions

    @chunhtai I was able to get back a GoRouteState.uri.host and GoRouteState.uri.scheme in our redirect with, seemingly, no side-effects by making the following changes:

    • parser.dart: configuration.findMatch(routeInformation.location!, extra: state.extra); changes to configuration.findMatch(routeInformation.uri.toString(), extra: state.extra);
    • information_provider.dart: location: routeInformation.location, changes to uri: routeInformation.uri,

    I can get moving on making a PR for this if this makes sense to you...
16. chunhtai commented on Dec 18, 2023

    

    chunhtai

    on Dec 18, 2023

    Last edited by chunhtai

    Contributor

    More actions

    You mention that you can tell whether a GoRouteState is a deep link by checking GoRouteState.uri.host and GoRouteState.uri.scheme. Both of these values are "" when I check them in the redirect, does this sound right?

    This is expected as of now, since go_router can't migrate to use RouteInformation.uri yet.

    Edit: looks like the stable has reach 3.12.0 and we should be able to use it now
17. chunhtai commented on Dec 18, 2023

    

    chunhtai

    on Dec 18, 2023

    Contributor

    More actions

    I can get moving on making a PR for this if this makes sense to you...

    yes, feel free to send out a pr.
18. chunhtai commented on Dec 18, 2023

    

    chunhtai

    on Dec 18, 2023

    Last edited by chunhtai

    Contributor

    More actions

    Actually I was wrong package is supporting 3.10.0 and up, so the routeinformation.uri isn't yet available.

    update: just consulted with eco team, it looks like we can bump the version to latest stable if we want to.
19. ChopinDavid commented on Dec 19, 2023

    

    ChopinDavid

    on Dec 19, 2023

    Last edited by ChopinDavid

    More actions

    @chuntai So, we would need a PR that:

    1. Upgrades go_router's min. flutter version to >=3.12.0 (so that RouteInformation.uri exists)
    2. Implements my aforementioned changes which make use of RouteInformation.uri rather than RouteInformation.location
    3. Adds new tests/makes sure that no tests are broken

    correct?
20. chunhtai commented on Dec 20, 2023

    

    chunhtai

    on Dec 20, 2023

    Contributor

    More actions

    @ChopinDavid that sounds correct
21. ChopinDavid commented on Dec 22, 2023

    

    ChopinDavid

    on Dec 22, 2023

    More actions

    PR is open @chunhtai: flutter/packages#5742
22. auto-submit

    closed this as completedin packages#5742on Feb 9, 2024
23. auto-submit

    added a commit that references this issue on Feb 9, 2024

    [go_router] Expose full `Uri` on `GoRouterState` in `GoRouterRedirect` (

    ...

    c269727
24. github-actions commented on Feb 23, 2024

    

    github-actionsbot

    on Feb 23, 2024 – with GitHub Actions

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
25. github-actions

    locked as resolved and limited conversation to collaborators on Feb 23, 2024