Skip to content

[CP] Fix Flutter doctor crash on Windows caused by bad UTF8 from vswhere.exe #104654

Closed
Closed
[CP] Fix Flutter doctor crash on Windows caused by bad UTF8 from vswhere.exe#104654
Labels
cp: approvedApproved cherry-pick request

Description

@loic-sharma
loic-sharma
opened on May 25, 2022

issue_link

#102451

Commit Hash

928bb12, c29a7a2

Target

stable

Impacted Users

Windows developers using the latest version of Visual Studio

Impact Description

Flutter doctor crashes on Windows on the latest version of Visual Studio for certain locales. See: #102451

Workaround

Yes, workarounds include

  1. Downgrade Visual Studio to an unaffected version
  2. Switch your locale to English
  3. Patch your Visual Studio installation and replace vswhere.exe with a pre-release build: https://github.com/microsoft/vswhere/releases

Risk

low

Test Coverage

yes

Validation Steps

There are three commits to cherry pick:

All of these commits contain unit tests. Manual testing that can be ensuring flutter doctor does not crash on Windows with the latest Visual Studio installation.

Activity

  1. loic-sharma
    added
    cp: reviewCherry-picks in the review queue
    on May 25, 2022

  2. itsjustkevin commented on May 26, 2022

    @itsjustkevin
    itsjustkevin
    on May 26, 2022
    Contributor

    @christopherfujino request your review on this CP

  3. christopherfujino commented on May 26, 2022

    @christopherfujino
    christopherfujino
    on May 26, 2022
    Contributor

    @christopherfujino request your review on this CP

    LGTM

  4. itsjustkevin
    added
    cp: approvedApproved cherry-pick request
    and removed
    cp: reviewCherry-picks in the review queue
    on May 26, 2022

  5. loic-sharma commented on Jun 1, 2022

    @loic-sharma
    loic-sharma
    on Jun 1, 2022
    MemberAuthor

    I added one more commit to the cherrypick: 52e19ef from #104133

  6. itsjustkevin commented on Jun 10, 2022

    @itsjustkevin
    itsjustkevin
    on Jun 10, 2022
    Contributor

    Flutter 3.0.2

  7. itsjustkevin
    closed this as completedon Jun 10, 2022

  8. github-actions commented on Jun 24, 2022

    @github-actions
    github-actionsbot
    on Jun 24, 2022

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. github-actions
    locked as resolved and limited conversation to collaborators on Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cp: approvedApproved cherry-pick request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions