Skip to content

Remove handling of the Flutter splash screen #105173

Closed
flutter-team-archive/engine
#44047
Closed
Remove handling of the Flutter splash screen#105173
flutter-team-archive/engine
#44047
Assignees
camsim99
Labels
P1High-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.platform-androidAndroid applications specificallyteam-androidOwned by Android platform teamtriaged-androidTriaged by Android platform team

Description

@blasten
blasten
opened on Jun 1, 2022

Flutter splash screen are deprecated: https://docs.flutter.dev/development/ui/advanced/splash-screen#migrating-from-manifest--activity-defined-custom-splash-screens

There are a number of apps that add the metadata io.flutter.embedding.android.SplashScreenDrawable to AndroidManifest.xml in g3.

Recently, the logic that lookups the drawable in the embedding is causing some issues on Android T beta.
See http://b/234598486, and http://b/231425885

This code can be removed from the engine assuming all 1P clients can be migrated.

Activity

  1. blasten
    added
    platform-androidAndroid applications specifically
    P1High-priority issues at the top of the work list
    c: tech-debtTechnical debt, code quality, testing, etc.
    on Jun 1, 2022

  2. blasten commented on Jun 1, 2022

    @blasten
    blasten
    on Jun 1, 2022
    Author

    cc @GaryQian

  3. Taym95 commented on Jun 10, 2022

    @Taym95
    Taym95
    on Jun 10, 2022
    Contributor

    Hi @blasten, I don't know if it is related to this issue, but adding custom splash screen to an activity(LaunchTheme) is not working anymore after removing io.flutter.embedding.android.SplashScreenDrawable , can you please point me to code responsible for that and I will try to help, thanks!

  4. camsim99
    self-assigned this
    on Jul 29, 2022

  5. khyati82 commented on Nov 21, 2022

    @khyati82
    khyati82
    on Nov 21, 2022

    @camsim99 - Has this been fixed and can this issue be closed?

  6. camsim99 commented on Nov 22, 2022

    @camsim99
    camsim99
    on Nov 22, 2022
    Contributor

    @khyati82 No, I am working on migrating people internal usages of it. After that, I'll discuss with my team a timeline for deleting it.

  7. camsim99
    added
    P2Important issues not at the top of the work list
    and removed
    P1High-priority issues at the top of the work list
    on Feb 6, 2023

  8. camsim99 commented on Feb 6, 2023

    @camsim99
    camsim99
    on Feb 6, 2023
    Contributor

    Working on migrating internal usages which is blocking this, so lowering in priority for now.

  9. flutter-triage-bot
    added
    team-androidOwned by Android platform team
    triaged-androidTriaged by Android platform team
    and removed
    triaged-androidTriaged by Android platform team
    on Jul 8, 2023

  10. flutter-triage-bot commented on Jul 9, 2023

    @flutter-triage-bot
    flutter-triage-botbot
    on Jul 9, 2023

    This issue is assigned but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

  11. camsim99 commented on Jul 10, 2023

    @camsim99
    camsim99
    on Jul 10, 2023
    Contributor

    Un-assigning me for now as I am not actively working on this.

  12. camsim99
    removed their assignment
    on Jul 10, 2023
  13. reidbaker
    assigned
    camsim99
    on Jul 13, 2023
  14. reidbaker
    added
    P1High-priority issues at the top of the work list
    triaged-androidTriaged by Android platform team
    and removed
    P2Important issues not at the top of the work list
    on Jul 13, 2023
  15. auto-submit
    added 2 commits that reference this issue on Jul 18, 2023

    [various] Deletes deprecated splash screen meta-data element (#4501)

    1fd191e

    [Android] Deletes deprecated splash screen meta-data element (#130744)

    b42879a
  16. auto-submit
    closed this as completedin flutter-team-archive/engine#44047on Jul 28, 2023
  17. auto-submit
    added a commit that references this issue on Jul 28, 2023

    [Android] Removes handling of Flutter splash screen (#44047)

    632b276
  18. LouiseHsu
    added a commit that references this issue on Jul 31, 2023

    [Android] Deletes deprecated splash screen meta-data element (flutter…

    dee40bc

  19. github-actions commented on Aug 11, 2023

    @github-actions
    github-actionsbot
    on Aug 11, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  20. github-actions
    locked as resolved and limited conversation to collaborators on Aug 11, 2023
  21. gaaclarke
    added a commit that references this issue on Aug 30, 2023

    [Android] Removes handling of Flutter splash screen (flutter-team-arc…

    be8c483
  22. zhongdaiqi
    added a commit that references this issue on Oct 9, 2026

    [Android] Removes handling of Flutter splash screen (flutter-team-arc…

    39cbbd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.platform-androidAndroid applications specificallyteam-androidOwned by Android platform teamtriaged-androidTriaged by Android platform team

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions