[flutter_tools] boolArg() should be non-nullable, and throw if the flag doesn't exist #105263

Activity

1. christopherfujino

   added

   c: new featureNothing broken; request for a new capabilityNothing broken; request for a new capability

   toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.

   P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter project

   on Jun 2, 2022
2. christopherfujino commented on Jun 2, 2022

   

   christopherfujino

   on Jun 2, 2022

   ContributorAuthor

   More actions

   WDYT @Jasguerrero ?
3. Jasguerrero commented on Jun 2, 2022

   

   Jasguerrero

   on Jun 2, 2022

   Contributor

   More actions

   SGTM
4. jmagman commented on Sep 10, 2022

   

   jmagman

   on Sep 10, 2022

   Member

   More actions

   My comment from the discussion was:

   @Jasguerrero I keep running into this pattern. Can we make boolArg return a nonnull bool to simplify the code, and have it throw an exception (not toolExit since it's a developer error) if the flag doesn't exist?

   Actually, I guess I'm essentially proposing going back to the old behavior from before #101595

   They make an assumption that the argument passed to them is valid therefore if the key is not found this methods raise an ArgumentError

   That seems like the correct behavior in most cases? The key isn't there, so it should throw. There's no paper trail from #101595 to see what issue the proposed pattern was solving when the key wasn't present.
5. christopherfujino commented on Mar 8, 2023

   

   christopherfujino

   on Mar 8, 2023

   ContributorAuthor

   More actions

   From a discussion in discord:

   • intArg is already deleted
   • for stringArg we should throw an ArgumentError if it wasn't parsed
   • for boolArg we should throw if it wasn't parsed and update the return type to bool
   • for stringsArg we should throw if it wasn't parsed
6. christopherfujino commented on Mar 8, 2023

   

   christopherfujino

   on Mar 8, 2023

   ContributorAuthor

   More actions

   cc @bartekpacia

   😄React with 😄1Reacted by Bartek Pacia
7. auto-submit

   closed this as completedin #122184on Mar 13, 2023
8. github-actions commented on Mar 27, 2023

   

   github-actionsbot

   on Mar 27, 2023

   More actions

   This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
9. github-actions

   locked as resolved and limited conversation to collaborators on Mar 27, 2023