Hide debug banner from Dartpad examples  #105959

Activity

1. TahaTesser commented on Jun 14, 2022

   

   TahaTesser

   on Jun 14, 2022

   Last edited by TahaTesser

   ContributorAuthor

   More actions

   cc: @guidezpl @gspencergoog

   Is there any reason to keep debug banner in examples at all?
   If not, could we hide it in all the examples?
2. TahaTesser

   added

   in triagePresently being triaged by the triage teamPresently being triaged by the triage team

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   p: material_uimaterial_ui package in flutter/packagesmaterial_ui package in flutter/packages

   d: examplesSample code and demosSample code and demos

   and removed

   in triagePresently being triaged by the triage teamPresently being triaged by the triage team

   on Jun 14, 2022
3. gspencergoog commented on Jun 15, 2022

   

   gspencergoog

   on Jun 15, 2022

   Contributor

   More actions

   Hmm. No, no reason. That's a good idea, I'm just not sure I want to add it to all of the examples, since typically we don't want users to turn that off (it's a good indicator for them, especially when starting out learning).

   Maybe there's a flag we can give Dartpad or something...

   👍React with 👍1Reacted by Taha Tesser
4. TahaTesser

   changed the title [-]Update API dartpad examples for debug banner to not cover `AppBar` action.[/-] [+]Hide `debug` banner from Dartpad examples [/+] on Jun 22, 2022
5. TahaTesser commented on Jun 22, 2022

   

   TahaTesser

   on Jun 22, 2022

   Last edited by TahaTesser

   ContributorAuthor

   More actions

   Hmm. No, no reason. That's a good idea, I'm just not sure I want to add it to all of the examples, since typically we don't want users to turn that off (it's a good indicator for them, especially when starting out learning).

   Maybe there's a flag we can give Dartpad or something...

   That makes sense, I propose a button in the Dartpad that disables the banner by default. When checking this menu option, the banner will be visible.

   Something like this

   

   This has been proposed here dart-lang/dart-pad#1391
6. gspencergoog commented on Jun 23, 2022

   

   gspencergoog

   on Jun 23, 2022

   Contributor

   More actions

   Sure. @redbrogdon is that a possibility? Or maybe there's already a flag for that?
7. guidezpl commented on Jun 23, 2022

   

   guidezpl

   on Jun 23, 2022

   Member

   More actions

   Backing up one step, why would someone want to show the banner? Feels like something only the sample writer cares about.
8. gspencergoog commented on Jun 23, 2022

   

   gspencergoog

   on Jun 23, 2022

   Contributor

   More actions

   Yeah, good point. I don't see any need for the banner at all in Dartpad.

   👍React with 👍1Reacted by Taha Tesser
9. redbrogdon commented on Sep 7, 2022

   

   redbrogdon

   on Sep 7, 2022

   Contributor

   More actions

   I always thought the banner was there to make sure people knew what kind of performance characteristics to expect when using the running application. DartPad has to use dartdevc in order to make the download size of the compiled code manageable (the Dart and Flutter SDKs can be precached that way), which means it's only capable of produced non-optimized, "debug" code.
10. TahaTesser commented on Feb 28, 2023

    

    TahaTesser

    on Feb 28, 2023

    ContributorAuthor

    More actions

    Closing this for dart-lang/dart-pad#1391
11. TahaTesser

    closed this as not plannedon Feb 28, 2023
12. github-actions commented on Mar 14, 2023

    

    github-actionsbot

    on Mar 14, 2023

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
13. github-actions

    locked as resolved and limited conversation to collaborators on Mar 14, 2023