RawScrollbar does not apply track or border color #106917

Activity

1. Piinks

   added

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   f: scrollingViewports, list views, slivers, etc.Viewports, list views, slivers, etc.

   a: qualityA truly polished experienceA truly polished experience

   P1High-priority issues at the top of the work listHigh-priority issues at the top of the work list

   on Jul 1, 2022
2. Piinks

   self-assigned this

   on Jul 1, 2022
3. MrPiou94 commented on Jul 5, 2022

   

   MrPiou94

   on Jul 5, 2022

   More actions

   Hello @Piinks ,
   This is my first contribution for Flutter, so I hope it will be sufficiently documented.
   After a few tries here is a proposal for the track color..

   trackVisibility: false, // Ignore colors well
   

   WithoutColor // Take default colors
   

   WithColor // Respects the chosen colors
   

   To do this, I modified the following files;
   flutter\packages\flutter\lib\src\widgets\scrollbar.dart

   1. In the creation of RawScrollbar, give the default color

       this.trackColor,
       this.trackBorderColor,

       this.trackColor = const Color(0x08000000),
       this.trackBorderColor = const Color(0x1a000000),

   2. Make colors not null because already initialized

     final Color? trackColor;
     final Color? trackBorderColor;

     final Color trackColor;
     final Color trackBorderColor;

   3. Show colors in updateScrollbarPainter only if trackVisibility: true

         ..trackColor = _showTrack ? const Color(0x08000000) : const Color(0x00000000)
         ..trackBorderColor = _showTrack ? const Color(0x1a000000) : const Color(0x00000000)

         ..trackColor = _showTrack ? widget.trackColor : const Color(0x00000000)
         ..trackBorderColor = _showTrack ? widget.trackBorderColor : const Color(0x00000000)

   I hope it will be useful for you, see you soon
4. Piinks

   added

   waiting for PR to land (fixed)A fix is in flightA fix is in flight

   on Jul 6, 2022
5. Piinks commented on Jul 6, 2022

   

   Piinks

   on Jul 6, 2022

   ContributorAuthor

   More actions

   Hey @MrPiou94 thanks for the detailed review! I already had a fix ready for this, it is in #107177. I am working on a large refactoring in this file and came across the bug.
   I am happy to hear you are interested in contributing! If you have not already done so, please check out the contributing guide. I'll be happy to give you a review on any changes you submit. Thanks - and welcome!

   👍React with 👍1Reacted by Pierre Fellendael
6. Piinks

   closed this as completedon Jul 7, 2022
7. github-actions commented on Jul 21, 2022

   

   github-actionsbot

   on Jul 21, 2022

   More actions

   This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
8. github-actions

   locked as resolved and limited conversation to collaborators on Jul 21, 2022