Skip to content

Path.combine doesn't work on web with the html renderer #108382

Closed as not planned
Closed as not planned

Description

@justinmc

Path.combine is unimplemented in the web engine for the html renderer.

Full context

  static Path combine(PathOperation operation, Path path1, Path path2) {
    assert(path1 != null); // ignore: unnecessary_null_comparison
    assert(path2 != null); // ignore: unnecessary_null_comparison
    if (engine.useCanvasKit) {
      return engine.CkPath.combine(operation, path1, path2);
    }
    throw UnimplementedError();
  }

However, the framework uses it in two places:

return Path.combine(PathOperation.union, rrect, arrow);

return Path.combine(PathOperation.difference, hostPath, guestPath);

Is it intentional that Path.combine can't be used on web with the html renderer? Should we be guarding against that in these two usages in the framework? CC @mdebbar

Activity

  1. yjbanov commented on Jul 26, 2022

    @yjbanov
    Contributor

    Deduplicating into #44572

  2. github-actions commented on Aug 9, 2022

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  3. locked as resolved and limited conversation to collaborators on Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    e: web_htmlHTML rendering backend for Webplatform-webWeb applications specifically

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions