Skip to content

Document how to share assets between Dart and OEM-side code #11019

Closed
Closed
Document how to share assets between Dart and OEM-side code#11019
Assignees
szakarias
Labels
a: assetsPackaging, accessing, or using assetscustomer: posse (eap)
Milestone
3: Current Milestone

Description

@lukef
lukef
opened on Jun 28, 2017

If you're creating an app that has native and flutter components there is no way to share images or fonts between flutter and android/ios. This means that assets needed on both sides will have to be included in the binary twice and that could be expensive.

Activity

  1. eseidelGoogle
    added
    customer: posse (eap)
    on Jun 29, 2017
  2. collinjackson
    added this to the 3: Current Milestone milestone on Jul 12, 2017
  3. collinjackson
    added
    customer blocker
    on Jul 12, 2017

  4. collinjackson commented on Jul 12, 2017

    @collinjackson
    collinjackson
    on Jul 12, 2017
    Contributor

    Posse has identified this as a launch blocker

  5. sethladd commented on Jul 12, 2017

    @sethladd
    sethladd
    on Jul 12, 2017
    Contributor

    Another reason to eliminate FLX? #9900

  6. collinjackson
    assigned
    tvolkert
    on Jul 12, 2017

  7. collinjackson commented on Jul 12, 2017

    @collinjackson
    collinjackson
    on Jul 12, 2017
    Contributor

    @tvolkert volunteered to take this one

  8. collinjackson
    removed
    customer blocker
    on Jul 12, 2017

  9. collinjackson commented on Jul 12, 2017

    @collinjackson
    collinjackson
    on Jul 12, 2017
    Contributor

    Priority has been adjusted, I removed customer blocker tag. Hopefully the extra breathing room will let us do this in the "right way" even if it takes longer.

  10. sethladd commented on Aug 1, 2017

    @sethladd
    sethladd
    on Aug 1, 2017
    Contributor

    I believe this came up again, in this Stack Overflow question: https://stackoverflow.com/questions/45428388/how-to-display-an-html-asset-file?utm_source=dlvr.it&utm_medium=twitter

    (there may be different solutions to the problem, but it might be easier if the .html file bundled with the app wasn't stuck inside the FLX?)

  11. Hixie commented on Aug 1, 2017

    @Hixie
    Hixie
    on Aug 1, 2017
    Contributor

    yes, we should just get rid of the FLX.

  12. Hixie commented on Dec 13, 2017

    @Hixie
    Hixie
    on Dec 13, 2017
    Contributor

    Leaving in current milestone since dropping FLX is on our short-term priority list.

  13. Hixie commented on Dec 13, 2017

    @Hixie
    Hixie
    on Dec 13, 2017
    Contributor

    cc @szakarias

  14. Hixie
    unassigned
    tvolkert
    on Dec 13, 2017
  15. szakarias
    added
    a: assetsPackaging, accessing, or using assets
    on Dec 13, 2017

  16. 3 remaining items

  17. cbracken commented on Feb 23, 2018

    @cbracken
    cbracken
    on Feb 23, 2018
    Member

    Related #11892.

    @szakarias any updates?

  18. tvolkert commented on Mar 6, 2018

    @tvolkert
    tvolkert
    on Mar 6, 2018
    Contributor

    @szakarias was this fixed by flutter-team-archive/engine#4742?

  19. MichaelSowah commented on Mar 6, 2018

    @MichaelSowah
    MichaelSowah
    on Mar 6, 2018

    @tvolkert https://github.com/flutter/flutter/issues/11019....am getting confused now about this asset issues all over...

  20. MichaelSowah commented on Mar 6, 2018

    @MichaelSowah
    MichaelSowah
    on Mar 6, 2018

    am also looking forward to being able to upload bulk images at once and dont need to do it one by one like its currently being handled...

  21. tvolkert commented on Mar 23, 2018

    @tvolkert
    tvolkert
    on Mar 23, 2018
    Contributor

    @szakarias with the asset re-work, we should be moving towards the goal of storing our assets in the locations that the underlying platform would otherwise store them. e.g. for Android,

    res/
    drawable/
    drawable-hdpi/
    drawable-mdpi/
    drawable-xhdpi/
    drawable-xxhdpi/
    drawable-xxxhdpi/

    There a suites of tools for packing, optimizing, and so forth an app's final bundle that gets distributed through app stores, and they all assume a certain layout of assets. Our current layout, harking from the days of FLX, doesn't play nicely with these tools. But now that we've gotten ourselves away from FLX, we should have more flexibility here.

    e.g. for Android, they're moving towards a model where you don't upload an APK to the Play Store, but rather upload all the constituent parts of your APK, and when a user installs an app, the store cleverly constructs the thinnest APK it can ship to the user, containing only the assets that make sense for that user's device-pixel-ratio, locale, etc.

    Just making sure that that end goal lines up with what this issue is tracking.

  22. szakarias commented on Mar 28, 2018

    @szakarias
    szakarias
    on Mar 28, 2018
    Contributor

    With the recent engine changes flutter-team-archive/engine#4817 and flutter-team-archive/engine#4785, it is now possible to share assets with native by accessing the Flutter assets through the main bundle on iOS and the AssetManager on Android. Once I document that on our website I will close this issue which is about avoiding asset duplication across platforms.

    As a next step it would be great to align even more with the underlying platform, I created #16015 to track this.

  23. Hixie
    added
    dev: docs - website
    on Apr 3, 2018
  24. Hixie
    changed the title [-]Cannot share assets between flutter and native[/-] [+]Document how to share assets between Dart and OEM-side code[/+] on Apr 3, 2018

  25. szakarias commented on Apr 6, 2018

    @szakarias
    szakarias
    on Apr 6, 2018
    Contributor

    Fixed, see the documentation.

  26. szakarias
    closed this as completedon Apr 6, 2018

  27. MichaelSowah commented on Apr 6, 2018

    @MichaelSowah
    MichaelSowah
    on Apr 6, 2018

    @szakarias are these fixes and changes in the dev channel yet or I need to be on master channel?

  28. szakarias commented on Apr 6, 2018

    @szakarias
    szakarias
    on Apr 6, 2018
    Contributor

    Should be on dev 0.2.7.

  29. MichaelSowah commented on Apr 6, 2018

    @MichaelSowah
    MichaelSowah
    on Apr 6, 2018

    @szakarias Thanks

  30. github-actions commented on Sep 3, 2021

    @github-actions
    github-actionsbot
    on Sep 3, 2021

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  31. github-actions
    locked as resolved and limited conversation to collaborators on Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

a: assetsPackaging, accessing, or using assetscustomer: posse (eap)

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions