Skip to content

Removing cpu from Mac tests in .ci.yaml still runs only on x64 machines #112117

Closed

Description

@jmagman

After #109889 I expected Mac hostonly tests to run on either arm or x64 depending on capacity. However the cpu dimension is still set to x86

Example:

flutter/.ci.yaml

Lines 2473 to 2484 in d98c263

- name: Mac dart_plugin_registry_test
recipe: devicelab/devicelab_drone
timeout: 60
properties:
dependencies: >-
[
{"dependency": "xcode", "version": "14a5294e"},
{"dependency": "gems", "version": "v3.3.14"}
]
tags: >
["devicelab", "hostonly"]
task_name: dart_plugin_registry_test

flutter/.ci.yaml

Lines 73 to 79 in d98c263

mac:
properties:
dependencies: >-
[]
os: Mac-12
device_type: none
xcode: 14a5294e # xcode 14.0 beta 5

When it ran it still has "cpu": "x86" set:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20dart_plugin_registry_test/7264/overview

And the swarming task only shows x64 bots as able to run it:
https://chromium-swarm.appspot.com/task?id=5d7adb0db77c1a10&o=true&w=true
https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=cpu&c=os&c=status&d=asc&f=pool%3Aluci.flutter.prod&f=os%3AMac-12&f=cpu%3Ax86&f=device_type%3Anone&s=id

Is there a cpu default set in infra somewhere?

@keyonghan

Activity

  1. keyonghan commented on Sep 21, 2022

    @keyonghan
    Contributor

    Your change does remove the cpu:x86 dimension: https://flutter-review.googlesource.com/c/infra/+/34205/2/config/generated/flutter/luci/cr-buildbucket.cfg#59474.

    But following landed commits (which are not rebased on top of your PR) forced the roller to roll back to earlier CI configs...

    This is a TD, and filed #112127 to track.

  2. jmagman commented on Sep 22, 2022

    @jmagman
    MemberAuthor

    Well we know this worked eventually because the tests started flaking #112130 🙂

    Closing, #112127 to track the ci config thrash.

  3. github-actions commented on Oct 6, 2022

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  4. locked as resolved and limited conversation to collaborators on Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    team-infraOwned by Infrastructure team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions