Skip to content

CI should fail if invalid subshard name is given. #112588

Description

@Jasguerrero

I think we should fail if invalid subshard name, I spent some time debugging why my shard was running integration tests and turns out that if you make this mistake _selectIndexOfTotalSubshard returns an empty array which then on _runDartTest if you pass an empty array you end up with a command like this run test --flags and then it runs every single test on your workingDirectory. I will make an issue to fix this

Originally posted by @Jasguerrero in #112505 (comment)

Activity

  1. github-actions commented on Nov 8, 2022

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  2. locked as resolved and limited conversation to collaborators on Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    c: contributor-productivityTeam-specific productivity, code health, technical debt.team-infraOwned by Infrastructure team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions