arm64 engine builds not compatible with --local-engine tool option #112679

Activity

1. yjbanov

   added

   c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.

   toolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.

   a: buildBuilding flutter applications with the toolBuilding flutter applications with the tool

   arch: m1

   on Sep 29, 2022
2. jmagman commented on Sep 29, 2022

   

   jmagman

   on Sep 29, 2022

   Last edited by jmagman

   Member

   More actions

   This indeed fails:

     testWithoutContext('works if local engine is host engine with suffixes', () async {
       final FileSystem fileSystem = MemoryFileSystem.test();
       final Directory localEngine = fileSystem
           .directory('$kArbitraryEngineRoot/src/out/host_debug_unopt_arm64/')
         ..createSync(recursive: true);
   
       final BufferLogger logger = BufferLogger.test();
       final LocalEngineLocator localEngineLocator = LocalEngineLocator(
         fileSystem: fileSystem,
         flutterRoot: 'flutter/flutter',
         logger: logger,
         userMessages: UserMessages(),
         platform: FakePlatform(environment: <String, String>{}),
       );
   
       expect(
         await localEngineLocator.findEnginePath(null, localEngine.path, null),
         matchesEngineBuildPaths(
           hostEngine: '/arbitrary/engine/src/out/host_debug_unopt_arm64',
           targetEngine: '/arbitrary/engine/src/out/host_debug_unopt_arm64',
         ),
       );
     });

   flutter/packages/flutter_tools/test/general.shard/runner/local_engine_test.dart

   Line 124 in fb8dcb8

   testWithoutContext('works if local engine is host engine', () async {

   cc @christopherfujino
3. cbracken commented on Sep 29, 2022

   

   cbracken

   on Sep 29, 2022

   Member

   More actions

   Closing as dupe of #103386
4. cbracken

   closed this as completedon Sep 29, 2022
5. cbracken

   reopened this on Sep 29, 2022
6. jmagman commented on Sep 29, 2022

   

   jmagman

   on Sep 29, 2022

   Member

   More actions

   Is it a duplicate? We could fix this without any gen_snapshot work.
7. jmagman commented on Sep 29, 2022

   

   jmagman

   on Sep 29, 2022

   Member

   More actions

   src$ ./flutter/tools/gn --unoptimized --mac-cpu=arm64
   ...
   Generating GN files in: out/host_debug_unopt_arm64
   
8. cbracken commented on Sep 29, 2022

   

   cbracken

   on Sep 29, 2022

   Last edited by cbracken

   Member

   More actions

   Reopened as not a dupe since this is specifically for --local-engine flag in the tool, which is one component of getting the above item done. It's very likely I'll hit this up while landing the rest of it though. If I can also get host/target builds untangled, then I'm hoping host_debug_unopt_arm64 can go away.

   Note that #103386 covers a ton more than just gen_snapshot. gen_snapshot is covered in the sub-issue you filed: #101138

   The broader issue I linked is migrating to the arm64 clang toolchain, enabling host unittests, updating tooling to work with the updated paths, etc. Generating universal binary gen_snapshots is one piece of that, but a pretty small part.

   👍React with 👍2Reacted by Jenn Magder and Aykut Kilic
9. jmagman

   self-assigned this

   on Nov 14, 2022
10. jmagman

    added

    P1High-priority issues at the top of the work listHigh-priority issues at the top of the work list

    on Nov 14, 2022
11. auto-submit

    closed this as completedin #115320on Nov 15, 2022
12. github-actions commented on Nov 29, 2022

    

    github-actionsbot

    on Nov 29, 2022

    More actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
13. github-actions

    locked as resolved and limited conversation to collaborators on Nov 29, 2022
14. Hixie

    added

    platform-macosBuilding on or for macOS specificallyBuilding on or for macOS specifically

    on Jul 5, 2023