Skip to content

Update scroll paging logic in Scrollbar #112893

Closed

Description

@Piinks

#105497 exposes the default computation of the page scroll increment of a ScrollAction.
This logic was duped in RawScrollbar to page the Scrollable when clicking the track.

When #105497 lands, we should use the newly exposed methods in RawScrollbar and remove the duplicated code. 👍

Activity

  1. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    f: scrollingViewports, list views, slivers, etc.
    on Oct 4, 2022
  2. added
    P2Important issues not at the top of the work list
    c: tech-debtTechnical debt, code quality, testing, etc.
    on Oct 10, 2022
  3. taniyarn commented on Feb 26, 2023

    @taniyarn
    Contributor

    @Piinks I added a fix for this in #121481.

  4. Piinks commented on Feb 27, 2023

    @Piinks
    ContributorAuthor

    Hey @tomohiko-tanihata thank you! I will take a look!

  5. github-actions commented on Mar 13, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  6. locked as resolved and limited conversation to collaborators on Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.f: scrollingViewports, list views, slivers, etc.frameworkflutter/packages/flutter repository. See also f: labels.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions