Skip to content

Remove strip_bitcode logic from engine scripts #112896

Closed
Closed
Remove strip_bitcode logic from engine scripts#112896
Assignees
cbracken
Labels
c: tech-debtTechnical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.platform-iosiOS applications specifically

Description

@jmagman
jmagman
opened on Oct 5, 2022

Starting with Xcode 14, bitcode is no longer required for watchOS and tvOS applications, and the App Store no longer accepts bitcode submissions from Xcode 14.

Most bitcode usage was removed in flutter-team-archive/engine#36596. Also remove strip_bitcode logic. See flutter-team-archive/engine#36496

https://github.com/flutter/engine/blob/2b8d506dff6d3f3bc9517cf5fe358d1d094fbcc5/sky/tools/macos.gni#L18-L20

# When we stop building with bitcode enabled, this template and the
# strip_bitcode.py script can be deleted and users can call copy() instead.

cc @cbracken

Activity

  1. jmagman
    added
    platform-iosiOS applications specifically
    engineflutter/engine related. See also e: labels.
    c: tech-debtTechnical debt, code quality, testing, etc.
    on Oct 5, 2022
  2. cbracken
    self-assigned this
    on Oct 5, 2022

  3. cbracken commented on Oct 5, 2022

    @cbracken
    cbracken
    on Oct 5, 2022
    Member

    I've got a patch together that covers the part of this that involves blowing away strip_bitcode and the surrounding script and template; just working through verifying the build outputs now.

  4. cbracken
    added a commit that references this issue on Oct 5, 2022

    [macOS][iOS] Eliminate strip_bitcode action (#36627)

    377bd08
  5. cbracken
    closed this as completedon Oct 5, 2022

  6. github-actions commented on Oct 20, 2022

    @github-actions
    github-actionsbot
    on Oct 20, 2022

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  7. github-actions
    locked as resolved and limited conversation to collaborators on Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

c: tech-debtTechnical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.platform-iosiOS applications specifically

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions