Skip to content

Expose alwaysShowMiddle as part of public API in CupertinoSliverNavigationBar #113542

Closed
#113544
Closed
Expose alwaysShowMiddle as part of public API in CupertinoSliverNavigationBar#113542
#113544
Labels
P1High-priority issues at the top of the work listc: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packages

Description

@campovski
campovski
opened on Oct 17, 2022

Use case

Currently, providing largeTitle and omitting middle to CupertinoSliverNavigationBar results in the same widget being used for
large title in expanded state and "middle title" in collapsed state, thus preventing a use of a different widget for collapsed state title (or just changing text style of the title for example). If we provide middle property as well (to be used as a title in collapsed state), both largeTitle and middle are visible when the nav bar is expanded (which is according to docs an expected behaviour). But, if we do not want such behaviour, it would be nice to have alwaysShowMiddle exposed with default value being widget.middle != null.

Proposal

Add alwaysShowMiddle as a field to CupertinoSliverNavigationBar and pass it to _LargeTitleNavigationBarSliverDelegate with default value of widget.middle != null.

Activity

  1. danagbemava-nc
    added
    in triagePresently being triaged by the triage team
    c: new featureNothing broken; request for a new capability
    frameworkflutter/packages/flutter repository. See also f: labels.
    p: cupertino_uicupertino_ui package in flutter/packages
    c: proposalA detailed proposal for a change to Flutter
    and removed
    in triagePresently being triaged by the triage team
    on Oct 18, 2022
  2. HansMuller
    assigned
    campovski
    on Oct 20, 2022
  3. Piinks
    added
    P1High-priority issues at the top of the work list
    on Oct 20, 2022

  4. campovski commented on Oct 21, 2022

    @campovski
    campovski
    on Oct 21, 2022
    ContributorAuthor

    @HansMuller The PR is ready for code review.

  5. campovski
    removed their assignment
    on Oct 21, 2022
  6. MitchellGoodwin
    closed this as completedin #113544on Oct 26, 2022

  7. github-actions commented on Nov 9, 2022

    @github-actions
    github-actionsbot
    on Nov 9, 2022

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  8. github-actions
    locked as resolved and limited conversation to collaborators on Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1High-priority issues at the top of the work listc: new featureNothing broken; request for a new capabilityc: proposalA detailed proposal for a change to Flutterframeworkflutter/packages/flutter repository. See also f: labels.p: cupertino_uicupertino_ui package in flutter/packages

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions