Skip to content

Windows_android channels_integration_test_win is 6.25% flaky #113706

Activity

  1. added
    engineflutter/engine related. See also e: labels.
    c: flakeTests that sometimes, but not always, incorrectly pass
    on Oct 19, 2022
  2. zanderso commented on Oct 19, 2022

    @zanderso
    Member

    Spot checking a few of these, they are hitting an assertion failure in the framework.

    package:flutter/src/gestures/binding.dart': Failed assertion: line 363 pos 14: '!_hitTests.containsKey(event.pointer)': Pointer of PointerDownEvent#f5eb4(position: Offset(316.0, 548.0)) unexpectedly has a HitTestResult associated with it.
    

    Routing to framework for triage.

  3. added
    frameworkflutter/packages/flutter repository. See also f: labels.
    and removed
    engineflutter/engine related. See also e: labels.
    on Oct 19, 2022
  4. goderbauer commented on Oct 25, 2022

    @goderbauer
    Member

    @dkwingsmt or @gspencergoog Any idea why we would be seeing a down event for something that has already a HitTestResult associated with it? I suspect, the down event is synthesized somewhere and maybe inserted incorrectly?

  5. fluttergithubbot commented on Oct 26, 2022

    @fluttergithubbot
    ContributorAuthor

    [staging pool] current flaky ratio for the past (up to) 100 commits is 0.00%. Flaky number: 0; total number: 95.

  6. dkwingsmt commented on Oct 28, 2022

    @dkwingsmt
    Contributor

    It seems that the tests have stabilized. It's probably caused by some other changes but it's really hard to just see from the code.

  7. fluttergithubbot commented on Nov 2, 2022

    @fluttergithubbot
    ContributorAuthor

    [staging pool] current flaky ratio for the past (up to) 100 commits is 0.00%. Flaky number: 0; total number: 100.

  8. Hixie commented on Nov 9, 2022

    @Hixie
    Contributor

    Looks like maybe this is bursty, with failures clumping up?

  9. fluttergithubbot commented on Nov 9, 2022

    @fluttergithubbot
    ContributorAuthor

    [staging pool] current flaky ratio for the past (up to) 100 commits is 0.00%. Flaky number: 0; total number: 100.

  10. Hixie commented on Nov 16, 2022

    @Hixie
    Contributor

    I had misread these updates, I didn't realise the prod pool updates are giving us old data (the commit hasn't changed in the last 3 updates, so it's still the same 6 failures). Meanwhile the staging pool is telling us there's no failures. I can't tell how recent that data is though (cc @keyonghan, i posted about this on #hackers-infra as well).

    Anyway if the test is only running on staging and hasn't flaked, is it time to turn it back on then?

  11. keyonghan commented on Nov 16, 2022

    @keyonghan
    Contributor

    The bot has been updating the bug with flake data from both staging and prod pool to cover all flake data. Please see #98999 (comment).

    Here the recent means the top commit runs in staging and prod. As the target is with bringup: true, it has not been running in prod pool. So the top commits still returns builds a while ago. Yeah, it would be clearer to have explicit info about the recent. Created #115403.

    Whenever the task shows 0 flake out of recent 100 runs in staging pool, test owner feels free to close the bug if they believe the issue is fixed or does not repro. The bot only auto deflakes the task when the tracking bug is closed.

  12. fluttergithubbot commented on Nov 16, 2022

    @fluttergithubbot
    ContributorAuthor

    [staging pool] current flaky ratio for the past (up to) 100 commits is 0.00%. Flaky number: 0; total number: 100.

  13. goderbauer commented on Nov 16, 2022

    @goderbauer
    Member

    Looks like this has been reliably unflaky for the last few weeks in staging. I am gonna close this bug.

    Whenever the task shows 0 flake out of recent 100 runs in staging pool, test owner feels free to close the bug if they believe the issue is fixed or does not repro. The bot only auto deflakes the task when the tracking bug is closed.

    @keyonghan Does this mean closing this bug is enough and a bot will remove the bringup: true or do I have to create a PR for that?

  14. keyonghan commented on Nov 17, 2022

    @keyonghan
    Contributor

    @keyonghan Does this mean closing this bug is enough and a bot will remove the bringup: true or do I have to create a PR for that?

    Right, the bot will auto deflake the task.

  15. github-actions commented on Dec 1, 2022

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  16. locked as resolved and limited conversation to collaborators on Dec 1, 2022
  17. added
    P0Critical issues such as a build break or regression
    and removed on Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P0Critical issues such as a build break or regressionc: flakeTests that sometimes, but not always, incorrectly passframeworkflutter/packages/flutter repository. See also f: labels.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions