Repository navigation
Windows_android channels_integration_test_win is 6.25% flaky #113706
Description
Activity
- addedengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.c: flakeTests that sometimes, but not always, incorrectly passTests that sometimes, but not always, incorrectly pass
on Oct 19, 2022 Spot checking a few of these, they are hitting an assertion failure in the framework.
package:flutter/src/gestures/binding.dart': Failed assertion: line 363 pos 14: '!_hitTests.containsKey(event.pointer)': Pointer of PointerDownEvent#f5eb4(position: Offset(316.0, 548.0)) unexpectedly has a HitTestResult associated with it.Routing to framework for triage.
- addedframeworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.and removedengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.
on Oct 19, 2022 @dkwingsmt or @gspencergoog Any idea why we would be seeing a down event for something that has already a HitTestResult associated with it? I suspect, the down event is synthesized somewhere and maybe inserted incorrectly?
fluttergithubbot commented
on Oct 26, 2022 ContributorAuthorMore actions[prod pool] current flaky ratio for the past (up to) 100 commits is 6.45%. Flaky number: 6; total number: 93.
One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5846
Commit: 9995e37
Flaky builds:
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5846
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5844
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5823
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5814
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5796
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5789Recent test runs:
https://flutter-dashboard.appspot.com/#/build?taskFilter=Windows_android%20channels_integration_test_winfluttergithubbot commented
on Oct 26, 2022 ContributorAuthorMore actions[staging pool] current flaky ratio for the past (up to) 100 commits is 0.00%. Flaky number: 0; total number: 95.
It seems that the tests have stabilized. It's probably caused by some other changes but it's really hard to just see from the code.
fluttergithubbot commented
on Nov 2, 2022 ContributorAuthorMore actions[prod pool] current flaky ratio for the past (up to) 100 commits is 6.67%. Flaky number: 6; total number: 90.
One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5846
Commit: 9995e37
Flaky builds:
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5846
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5844
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5823
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5814
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5796
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5789Recent test runs:
https://flutter-dashboard.appspot.com/#/build?taskFilter=Windows_android%20channels_integration_test_winfluttergithubbot commented
on Nov 2, 2022 ContributorAuthorMore actions[staging pool] current flaky ratio for the past (up to) 100 commits is 0.00%. Flaky number: 0; total number: 100.
Looks like maybe this is bursty, with failures clumping up?
fluttergithubbot commented
on Nov 9, 2022 ContributorAuthorMore actions[prod pool] current flaky ratio for the past (up to) 100 commits is 6.98%. Flaky number: 6; total number: 86.
One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5846
Commit: 9995e37
Flaky builds:
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5846
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5844
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5823
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5814
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5796
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5789Recent test runs:
https://flutter-dashboard.appspot.com/#/build?taskFilter=Windows_android%20channels_integration_test_winfluttergithubbot commented
on Nov 9, 2022 ContributorAuthorMore actions[staging pool] current flaky ratio for the past (up to) 100 commits is 0.00%. Flaky number: 0; total number: 100.
I had misread these updates, I didn't realise the prod pool updates are giving us old data (the commit hasn't changed in the last 3 updates, so it's still the same 6 failures). Meanwhile the staging pool is telling us there's no failures. I can't tell how recent that data is though (cc @keyonghan, i posted about this on #hackers-infra as well).
Anyway if the test is only running on staging and hasn't flaked, is it time to turn it back on then?
The bot has been updating the bug with flake data from both staging and prod pool to cover all flake data. Please see #98999 (comment).
Here the recent means the top commit runs in staging and prod. As the target is with
bringup: true, it has not been running inprodpool. So the top commits still returns builds a while ago. Yeah, it would be clearer to have explicit info about therecent. Created #115403.Whenever the task shows 0 flake out of recent 100 runs in staging pool, test owner feels free to close the bug if they believe the issue is fixed or does not repro. The bot only auto deflakes the task when the tracking bug is closed.
fluttergithubbot commented
on Nov 16, 2022 ContributorAuthorMore actions[prod pool] current flaky ratio for the past (up to) 100 commits is 6.82%. Flaky number: 3; total number: 44.
One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5846
Commit: 9995e37
Flaky builds:
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5846
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5844
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5823Recent test runs:
https://flutter-dashboard.appspot.com/#/build?taskFilter=Windows_android%20channels_integration_test_winfluttergithubbot commented
on Nov 16, 2022 ContributorAuthorMore actions[staging pool] current flaky ratio for the past (up to) 100 commits is 0.00%. Flaky number: 0; total number: 100.
Looks like this has been reliably unflaky for the last few weeks in staging. I am gonna close this bug.
Whenever the task shows 0 flake out of recent 100 runs in staging pool, test owner feels free to close the bug if they believe the issue is fixed or does not repro. The bot only auto deflakes the task when the tracking bug is closed.
@keyonghan Does this mean closing this bug is enough and a bot will remove the
bringup: trueor do I have to create a PR for that?@keyonghan Does this mean closing this bug is enough and a bot will remove the bringup: true or do I have to create a PR for that?
Right, the bot will auto deflake the task.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.- locked as resolved and limited conversation to collaborators
on Dec 1, 2022 - addedP0Critical issues such as a build break or regressionCritical issues such as a build break or regressionand removed
on Jun 28, 2023
The post-submit test builder
Windows_android channels_integration_test_winhad a flaky ratio 6.25% for the past (up to) 100 commits, which is above our 2.00% threshold.One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5846
Commit: 9995e37
Flaky builds:
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5846
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5844
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5823
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5814
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5796
https://ci.chromium.org/ui/p/flutter/builders/prod/Windows_android%20channels_integration_test_win/5789
Recent test runs:
https://flutter-dashboard.appspot.com/#/build?taskFilter=Windows_android%20channels_integration_test_win
Please follow https://github.com/flutter/flutter/wiki/Reducing-Test-Flakiness#fixing-flaky-tests to fix the flakiness and enable the test back after validating the fix (internal dashboard to validate: go/flutter_test_flakiness).