Repository navigation
RangeError when both removing listener and disposing ValueNotifier from listener callback #114224
Description
This code
void main() {
final vn = ValueNotifier<int>(0);
void foo() {
vn.removeListener(foo); // A
vn.dispose(); // B
}
vn.addListener(foo);
vn.value = 3;
}results in:
flutter: RangeError (length): Invalid value: Not in inclusive range 0..576460752303423487: -1, #0 new _List (dart:core-patch/array.dart)
#1 ChangeNotifier.notifyListeners (package:flutter/src/foundation/change_notifier.dart:384:50)
#2 ValueNotifier.value= (package:flutter/src/foundation/change_notifier.dart:463:5)
while I would expect it to work. There is no exception when either line A or line B is removed.
Issue can be fixed by setting also _reentrantlyRemovedListeners to zero in dispose here:
[!] Flutter (Channel unknown, 3.3.2, on macOS 12.5.1 21G83 darwin-arm, locale en-NL)
! Flutter version 3.3.2 on channel unknown at /.../flutter
! Upstream repository unknown
• Framework revision e3c29ec00c (6 weeks ago), 2022-09-14 08:46:55 -0500
• Engine revision a4ff2c53d8
• Dart version 2.18.1
• DevTools version 2.15.0
Activity
huycozy commentedon Oct 31, 2022
Hi @spkersten, this issue is reproducible on the latest
stableandmasterchannels with provided sample code.The error message is a little different from yours. Labeling this issue for further investigation.
Logs
flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.3.6, on macOS 12.6 21G115 darwin-x64, locale en-VN) • Flutter version 3.3.6 on channel stable at /Users/huynq/Documents/GitHub/flutter • Upstream repository https://github.com/flutter/flutter.git • Framework revision 6928314d50 (30 hours ago), 2022-10-25 16:34:41 -0400 • Engine revision 3ad69d7be3 • Dart version 2.18.2 • DevTools version 2.15.0 [✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0) • Android SDK at /Users/huynq/Library/Android/sdk • Platform android-33, build-tools 31.0.0 • ANDROID_HOME = /Users/huynq/Library/Android/sdk • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866) • All Android licenses accepted. [✓] Xcode - develop for iOS and macOS (Xcode 14.0.1) • Xcode at /Applications/Xcode14.0.1.app/Contents/Developer • Build 14A400 • CocoaPods version 1.11.3 [✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [✓] Android Studio (version 2021.3) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866) [✓] IntelliJ IDEA Community Edition (version 2022.2.2) • IntelliJ at /Applications/IntelliJ IDEA CE.app • Flutter plugin version 70.0.5 • Dart plugin version 222.4167.21 [✓] IntelliJ IDEA Community Edition (version 2022.1.1) • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart [✓] VS Code (version 1.72.2) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 3.50.0 [✓] Connected device (3 available) • SM T225 (mobile) • R9JT3004VRJ • android-arm64 • Android 12 (API 31) • macOS (desktop) • macos • darwin-x64 • macOS 12.6 21G115 darwin-x64 • Chrome (web) • chrome • web-javascript • Google Chrome 107.0.5304.62 [✓] HTTP Host Availability • All required HTTP hosts are available • No issues found!chunhtai commentedon Nov 2, 2022
I think we should disallow calling dispose in the listener callback. https://api.flutter.dev/flutter/foundation/ChangeNotifier/dispose.html
The document suggest only the owner should call this method.
spkersten commentedon Nov 2, 2022
That could be difficult to prevent if a few layers of indirection are present.
chunhtai commentedon Nov 2, 2022
If we allows it, it will be hard to manage its lifecycle, and we also need to figure out what would happen after the dispose is called.
This will require delay dispose which is very error prompt and hard to maintain. and we also need to worry about multiple of them may call dispose as well.
In this case the invoke order would matter, but we don't guarantee invoke order IIRC. So it would create inconsistent behavior.
I think our current code with your suggestion will be implementing (2).
I can't think of a case that calling dispose in listener is a valid use case. Do you have any use case that this may be more preferred?
chunhtai commentedon Nov 2, 2022
I created #114530, but we should keep the conversation going since this may be a hard breaking change
github-actions commentedon Dec 2, 2022
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.