Skip to content

[CP] NestedScrollView+trackpad regression fix #117027

Closed

Description

@Piinks

issue_link

#116486

Commit Hash

97df2b3

Target

beta

pr_link

#117343

Impacted Users

This issue affected Mac and Windows targets using a trackpad to scroll NestedScrollViews.

Impact Description

This fixes an issue with trackpad input where the scroll position would suddenly change when stopping the scrolling action. Stopping a trackpad scrolling activity (as in touching the trackpad to stop active scrolling) worked as expected in a other scroll views, this only affected the NestedScrollView as it has a custom position implementation that was not taken into account when the feature was first added. The linked PR fixed the issue.

Workaround

No.

Risk

low

Test Coverage

yes

Validation Steps

Scrolling and stopping in a NestedScrollView with a trackpad does not create unexpected behavior (scroll position going way off in the other direction). The regression is tested and verified.

Activity

  1. itsjustkevin commented on Dec 14, 2022

    @itsjustkevin
    Contributor

    @HansMuller could you take a look?

  2. HansMuller commented on Dec 14, 2022

    @HansMuller
    Contributor

    LGTM

  3. Piinks commented on Dec 19, 2022

    @Piinks
    ContributorAuthor

    Cherry pick pull request: #117343

  4. github-actions commented on Mar 4, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  5. locked as resolved and limited conversation to collaborators on Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cp: approvedApproved cherry-pick requestcp: merge-to-betaCherry-picks that should be merged to betacp: reviewCherry-picks in the review queue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions