Skip to content

[CP] Fix NavigationRail highlight #117340

Closed
Closed

Description

@Piinks

issue_link

#117126

Commit Hash

5fcb48d

Target

beta

pr_link

#117344

Impacted Users

Users of the Material 3 spec

Impact Description

This fixed a regression introduced in #116108
The new Material 3 NavigationRail was rendering the highlight in the wrong location.

image

Workaround

No.

Risk

low

Test Coverage

yes

Validation Steps

This dartpad reproduced the issue. https://dartpad.dev/?id=272d62da895a9e17c38c7f562a6d3d5f&channel=master

Activity

  1. itsjustkevin commented on Dec 19, 2022

    @itsjustkevin
    Contributor

    @HansMuller could you check out this cherry-pick request?

  2. HansMuller commented on Dec 19, 2022

    @HansMuller
    Contributor

    LGTM

  3. Piinks commented on Dec 19, 2022

    @Piinks
    ContributorAuthor

    Cherry pick PR is #117344

  4. github-actions commented on Mar 4, 2023

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  5. locked as resolved and limited conversation to collaborators on Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cp: approvedApproved cherry-pick requestcp: merge-to-betaCherry-picks that should be merged to betacp: reviewCherry-picks in the review queue

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions