Repository navigation
[camera] Convert to Pigeon #117905
Description
Activity
- added a commit that references this issue
on Apr 17, 2024 - added a commit that references this issue
on Apr 17, 2024 Hi,
I upgraded my package lately and got this:> camera_avfoundation 0.9.15+2 (was 0.9.15+1) ! flutter_secure_storage_web 1.2.0 from git https://github.com/ThexXTURBOXx/flutter_secure_storage.git at 6ac827 in flutter_secure_storage_web (overridden) intl 0.18.1 (0.19.0 available) leak_tracker 10.0.0 (10.0.5 available) leak_tracker_flutter_testing 2.0.1 (3.0.5 available) leak_tracker_testing 2.0.1 (3.0.1 available) material_color_utilities 0.8.0 (0.11.1 available) meta 1.11.0 (1.14.0 available) pdf_widget_wrapper 1.0.3 (1.0.4 available) + pigeon 18.0.0 test_api 0.6.1 (0.7.1 available) vm_service 13.0.0 (14.2.1 available) Changed 2 dependencies!camera_avfoundation uses pigeon in the dependencies block instead of the dev dependencies. It should be moved there since there is no "import package:pigeon" in the code.
- added a commit that references this issue
on Apr 18, 2024 @CodeDoctorDE Thanks, I missed the
--devflag when adding the dependency. I have a PR up to fix it, and prevent it from happening in the future.Reacted by CodeDoctor20 remaining items
I strongly recommend doing this incrementally, as I did for iOS, given the API surface size. For reference:
- [camera] Initial iOS Pigeon conversion packages#6553 just converted a single host method, to get all the Pigeon plumbing wired up.
- [camera] Convert iOS Obj-C->Dart calls to Pigeon packages#6568 just converted the native->Dart calls. (This could easily be split into two PRs, one for global and one for per-camera calls)
- [camera] Finish converting iOS to Pigeon packages#6601 converted the rest of the host APIs. (This can easily be carved up smaller; just pick one set of methods—or even a single method—migrate those as a PR, repeat.)
- unlocked this conversation
on Oct 8, 2024 @stuartmorgan With this done for
camera_android, should we close this issue now?Yes! 🎉
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.- locked as resolved and limited conversation to collaborators
on Nov 1, 2024 - added a commit that references this issue
on Jun 10, 2026 - added a commit that references this issue
on Jun 19, 2026
Part of #117844
This is a case where we may want to build more instance-tracking functionality into Pigeon itself before doing a conversion, since we currently use per-instance channels.
camera_android.camera_avfoundationcamera_windows