Skip to content

[web] Update needed for the updated directory structure in the Dart SDK #118119

Closed
#118120
Closed
[web] Update needed for the updated directory structure in the Dart SDK#118119
#118120
Labels
platform-webWeb applications specificallytoolAffects the "flutter" command-line tool. See also t: labels.

Description

@nshahan
nshahan
opened on Jan 6, 2023

For Dart 3.0 I am cleaning up the assets packaged in the Dart SDK for the development web compiler. I'm deleting files that are unused and cleaning up the extraneous sub-directories dart-lang/sdk#50700.

As far as I can tell the only issue this will cause is when require.js is read from the Dart SDK.

flutter/packages/flutter_tools/lib/src/isolated/devfs_web.dart

Lines 929 to 936 in db1c3e2

final File requireJS = globals.fs.file(globals.fs.path.join(
globals.artifacts!.getArtifactPath(Artifact.engineDartSdkPath, platform: TargetPlatform.web_javascript),
'lib',
'dev_compiler',
'kernel',
'amd',
'require.js',
));

The fix will be very simple and I have a PR prepared.
#118120

I'd like guidance in how to land properly or whom to notify since it will break after I land my change in the Dart SDK and it gets rolled into engine, and then into flutter.

A second set of eyes looking at the issue linked above to identify any other potential problems would be helpful as well.

Activity

  1. huycozy
    added
    in triagePresently being triaged by the triage team
    toolAffects the "flutter" command-line tool. See also t: labels.
    platform-webWeb applications specifically
    and removed
    in triagePresently being triaged by the triage team
    on Jan 9, 2023

  2. kevmoo commented on Jan 9, 2023

    @kevmoo
    kevmoo
    on Jan 9, 2023
    Contributor

    I'm guessing we'll just need to have a world where both exist – one falling back to the other – until we do the cross over.

    @hterkelsen @yjbanov ?

  3. nshahan commented on Jan 9, 2023

    @nshahan
    nshahan
    on Jan 9, 2023
    ContributorAuthor

    Yes, I'm working on a change that will support either location and then a followup to remove the old once my SDK change rolls all the way through.

  4. nshahan
    closed this as completedin #118120on Jan 9, 2023
  5. nshahan
    added a commit that references this issue on Jan 18, 2023

    Fix path for require.js

    e203a31
  6. iskakaushik
    added a commit that references this issue on Jan 18, 2023

    Fix path for require.js (#118722)

    bb8b96a
  7. gspencergoog
    added a commit that references this issue on Jan 19, 2023

    Fix path for require.js (flutter#118722)

    24d17cb

  8. github-actions commented on Mar 4, 2023

    @github-actions
    github-actionsbot
    on Mar 4, 2023

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  9. github-actions
    locked as resolved and limited conversation to collaborators on Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    platform-webWeb applications specificallytoolAffects the "flutter" command-line tool. See also t: labels.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions